shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-01-10 05:18:17 +03:00
Code

timedatectl: setting set_local_rtc to 1 will throw Warning as well, use log_warning() (#33489)

Browse Source 
Previously only running `timedatectl` it was showing warning regarding the dangers of setting RTC to local TZ.
Now similar warning is also flashed when `set-local-rtc 1`.
This commit is contained in:
ShreyasMahangade 2024-07-20 22:37:30 +05:30 committed by GitHub
parent 8da20e3fe2
commit db708fc9ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/timedate/timedatectl.c
View File

@ -149,14 +149,15 @@ static int print_status_info(const StatusInfo *i) {
if (r < 0)
return table_log_print_error(r);
if (i->rtc_local)
printf("\n%s"
"Warning: The system is configured to read the RTC time in the local time zone.\n"
" This mode cannot be fully supported. It will create various problems\n"
" with time zone changes and daylight saving time adjustments. The RTC\n"
" time is never updated, it relies on external facilities to maintain it.\n"
" If at all possible, use RTC in UTC by calling\n"
" 'timedatectl set-local-rtc 0'.%s\n", ansi_highlight(), ansi_normal());
if (i->rtc_local) {
fflush(stdout);
log_warning(" \nWarning: The system is configured to read the RTC time in the local time zone.\n"
" This mode cannot be fully supported. It will create various problems\n"
" with time zone changes and daylight saving time adjustments. The RTC\n"
" time is never updated, it relies on external facilities to maintain it.\n"
" If at all possible, use RTC in UTC by calling\n"
" 'timedatectl set-local-rtc 0'.\n");
}
return 0;
}
@ -261,6 +262,13 @@ static int set_local_rtc(int argc, char **argv, void *userdata) {
if (b < 0)
return log_error_errno(b, "Failed to parse local RTC setting '%s': %m", argv[1]);
if (b == 1)
log_warning("Warning: The system is now being configured to read the RTC time in the local time zone\n"
" This mode cannot be fully supported. It will create various problems\n"
" with time zone changes and daylight saving time adjustments. The RTC\n"
" time is never updated, it relies on external facilities to maintain it.\n"
" If at all possible, use RTC in UTC");
r = bus_call_method(
bus,
bus_timedate,