shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-08-03 08:22:21 +03:00
Code Activity

execute: add FIXME comment

Browse Source 
As requested by @YHNdnzj:

https://github.com/systemd/systemd/pull/33707#discussion_r1684055699
This commit is contained in:
Lennart Poettering
2024-07-19 14:40:47 +02:00
parent af63b4b769
commit e846854172
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/exec-invoke.c
View File

@ -497,6 +497,9 @@ static int setup_output(
i = fixup_input(context, socket_fd, params->flags & EXEC_APPLY_TTY_STDIN); i = fixup_input(context, socket_fd, params->flags & EXEC_APPLY_TTY_STDIN);
o = fixup_output(context->std_output, socket_fd); o = fixup_output(context->std_output, socket_fd);
// FIXME: we probably should spend some time here to verify that if we inherit an fd from stdin
// (possibly indirect via inheritance from stdout) it is actually opened for write!
if (fileno == STDERR_FILENO) { if (fileno == STDERR_FILENO) {
ExecOutput e; ExecOutput e;
e = fixup_output(context->std_error, socket_fd); e = fixup_output(context->std_error, socket_fd);