shaba/systemd
1
0
Fork 0
mirror of https://github.com/systemd/systemd.git synced 2025-09-03 21:44:51 +03:00
Code Activity

exec-util: use open_terminal() in fork_agent() for safety

Browse Source
This commit is contained in:
Yu Watanabe
2024-12-03 18:58:11 +09:00
parent 90579fd0b3
commit f0ace1655d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/shared/exec-util.c
View File

@@ -594,9 +594,9 @@ int _fork_agent(const char *name, const int except[], size_t n_except, pid_t *re
* that when systemctl is started via popen() or a similar call that expects to read EOF we * that when systemctl is started via popen() or a similar call that expects to read EOF we
* actually do generate EOF and not delay this indefinitely by keeping an unused copy of * actually do generate EOF and not delay this indefinitely by keeping an unused copy of
* stdin around. */ * stdin around. */
fd = open("/dev/tty", stdin_is_tty ? O_WRONLY : (stdout_is_tty && stderr_is_tty) ? O_RDONLY : O_RDWR); fd = open_terminal("/dev/tty", stdin_is_tty ? O_WRONLY : (stdout_is_tty && stderr_is_tty) ? O_RDONLY : O_RDWR);
if (fd < 0) { if (fd < 0) {
log_error_errno(errno, "Failed to open /dev/tty: %m"); log_error_errno(fd, "Failed to open /dev/tty: %m");
_exit(EXIT_FAILURE); _exit(EXIT_FAILURE);
} }