mirror of
https://github.com/systemd/systemd.git
synced 2025-01-10 05:18:17 +03:00
fileio: try to read one byte too much in read_full_stream()
Let's read one byte more than the file size we read from stat() on the first fread() invocation. That way, the first read() will already be short and indicate eof to fread(). This is a minor optimization, and replaces #3908.
This commit is contained in:
parent
9dd1b1e869
commit
ff0e7e05c9
@ -270,11 +270,11 @@ int read_full_stream(FILE *f, char **contents, size_t *size) {
|
||||
if (st.st_size > READ_FULL_BYTES_MAX)
|
||||
return -E2BIG;
|
||||
|
||||
/* Start with the right file size, but be prepared for
|
||||
* files from /proc which generally report a file size
|
||||
* of 0 */
|
||||
/* Start with the right file size, but be prepared for files from /proc which generally report a file
|
||||
* size of 0. Note that we increase the size to read here by one, so that the first read attempt
|
||||
* already makes us notice the EOF. */
|
||||
if (st.st_size > 0)
|
||||
n = st.st_size;
|
||||
n = st.st_size + 1;
|
||||
}
|
||||
|
||||
l = 0;
|
||||
|
Loading…
Reference in New Issue
Block a user