1
0
mirror of https://github.com/systemd/systemd.git synced 2024-12-22 17:35:35 +03:00

tests: add a smoke test for --version option in binaries

This is very similar to (and directly based on) the test for --help. I think
it's nice to do this: the test is very quick, but it'll catch cases where we
forgot to hook up the option, or forgot to exit after printing --version, and
it'll also increase our test coverage a bit.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2022-04-05 10:51:21 +02:00
parent 42ac3bf1a3
commit ffb7406ba9
3 changed files with 47 additions and 4 deletions

View File

@ -3891,6 +3891,7 @@ endif
############################################################ ############################################################
check_help = find_program('tools/check-help.sh') check_help = find_program('tools/check-help.sh')
check_version = find_program('tools/check-version.sh')
foreach exec : public_programs foreach exec : public_programs
name = exec.full_path().split('/')[-1] name = exec.full_path().split('/')[-1]
@ -3899,6 +3900,12 @@ foreach exec : public_programs
check_help, check_help,
args : exec.full_path(), args : exec.full_path(),
depends: exec) depends: exec)
test('check-version-' + name,
check_version,
args : [exec.full_path(),
meson.project_version()],
depends: exec)
endif endif
endforeach endforeach

View File

@ -3,8 +3,8 @@
set -eu set -eu
set -o pipefail set -o pipefail
# Note: `grep ... >/dev/null` instead of just `grep -q` is used intentionally # Note: 'grep ... >/dev/null' instead of just 'grep -q' is used intentionally
# here, since `grep -q` exits on the first match causing SIGPIPE being # here, since 'grep -q' exits on the first match causing SIGPIPE being
# sent to the sender. # sent to the sender.
BINARY="${1:?}" BINARY="${1:?}"
@ -24,11 +24,11 @@ fi
# --help prints something. Also catches case where args are ignored. # --help prints something. Also catches case where args are ignored.
if ! "$BINARY" --help | grep . >/dev/null; then if ! "$BINARY" --help | grep . >/dev/null; then
echo "$(basename "$BINARY") --help output is empty." echo "$(basename "$BINARY") --help output is empty"
exit 2 exit 2
fi fi
# no --help output to stdout # no --help output to stderr
if "$BINARY" --help 2>&1 1>/dev/null | grep .; then if "$BINARY" --help 2>&1 1>/dev/null | grep .; then
echo "$(basename "$BINARY") --help prints to stderr" echo "$(basename "$BINARY") --help prints to stderr"
exit 3 exit 3

36
tools/check-version.sh Executable file
View File

@ -0,0 +1,36 @@
#!/usr/bin/env bash
# SPDX-License-Identifier: LGPL-2.1-or-later
set -eu
set -o pipefail
# Note: 'grep ... >/dev/null' instead of just 'grep -q' is used intentionally
# here, since 'grep -q' exits on the first match causing SIGPIPE being
# sent to the sender.
BINARY="${1:?}"
VERSION="${2:?}"
export SYSTEMD_LOG_LEVEL=info
if [[ ! -x "$BINARY" ]]; then
echo "$BINARY is not an executable"
exit 1
fi
# --version prints something. Also catches case where args are ignored.
if ! "$BINARY" --version | grep . >/dev/null; then
echo "$(basename "$BINARY") --version output is empty"
exit 2
fi
# no --version output to stderr
if "$BINARY" --version 2>&1 1>/dev/null | grep .; then
echo "$(basename "$BINARY") --version prints to stderr"
exit 3
fi
# project version appears in version output
out="$("$BINARY" --version)"
if ! grep -F "$VERSION" >/dev/null <<<"$out"; then
echo "$(basename "$BINARY") --version output does not match '$VERSION': $out"
exit 4
fi