1
0
mirror of https://github.com/systemd/systemd.git synced 2024-12-23 21:35:11 +03:00
Commit Graph

65665 Commits

Author SHA1 Message Date
Lennart Poettering
08e0ed300a sleep-config: check if we operate on regular file in swap_device_to_device_id() in swap file code path
Similar to the previous commit: before we continue doing swap file
operations let's ensure this actually is a swap file.
2023-06-20 13:13:54 +02:00
Lennart Poettering
1cf78c8f78 sleep-config: replace useless fstat() by useful fd_verify_regular()
For some reason there was an fstat() call here whose results was
entirely ignored. Let's remove it. Let's add a call to
fd_verify_regular() instead, because this is a code path for swap files,
hence let's make sure we actually operate on a file, and nothing else.
2023-06-20 13:11:53 +02:00
Lennart Poettering
fd6ec01d28 sleep-config: rename can_sleep_state() parameter
Just some trivial renaming, to indicate that these are not the supported
but the requested sleep states.
2023-06-20 13:11:53 +02:00
Lennart Poettering
3044510d58 transaction: drop bus error arg from transaction_add_propagate_reload_jobs()
We erase the error anyway always, hence no point in even passing
anything in from callers.
2023-06-20 13:07:55 +02:00
Lennart Poettering
c25eeb65c0 transaction: rebreak comments to match current coding style 2023-06-20 13:02:09 +02:00
Lennart Poettering
fab7e5e8f6 transaction: use more verbose dbus error data in log message where available 2023-06-20 13:02:09 +02:00
Lennart Poettering
b0904249b9 transaction: turn four bool parameters into a proper flags parameters 2023-06-20 13:02:09 +02:00
Mike Yuan
68f8a86a46 gpt-auto: expand the loader partition UUID check to include XBOOTLDR
Before this commit, we only accept the case when LoaderDevicePartUUID
points to the ESP, while XBOOTLDR is mounted unconditionally.

After this commit, we check if LoaderDevicePartUUID points to either
ESP or XBOOTLDR. If it does, mount both, else nothing gets mounted.
2023-06-20 11:15:48 +02:00
licunlong
b4ff8ba077 NEWS: note the incompatible change of EnvironmentFile 2023-06-20 14:42:48 +08:00
licunlong
cd93ec5ed2 basic/env-file: also change to state PRE_KEY if we see NEWLINE in state COMMENT_ESCAPE
When we see a "\" in COMMENT state, we change the state to COMMENT_ESCAPE. When we got
a new character, we reset the state to COMMENT, but this character is not dispatched.
Usually the character is NEWLINE, if so we will stay in COMMENT state until we find
the next NEWLINE.

fix: https://github.com/systemd/systemd/issues/27975
2023-06-20 14:42:44 +08:00
cvlc12
1c2c00dbb6 Fix quoting 2023-06-20 00:51:32 +01:00
Frantisek Sumsal
5b9dfd33c6 sysusers.d: create the user for systemd-journal-upload.service 2023-06-19 23:42:00 +02:00
Frantisek Sumsal
0096917d08 journal-upload: capitalize all error messages
To make them consistent throughout the file.
2023-06-19 23:42:00 +02:00
Frantisek Sumsal
2530af2ecc journal-remote: capitalize all error messages
To make them consistent throughout the file.
2023-06-19 23:42:00 +02:00
Frantisek Sumsal
d7085bcc7d journal-remote: sync TrustedCertificateFile= parsing with journal-upload
So we can use TrustedCertificateFile=- to disable certificate checking
for both utilities.
2023-06-19 23:42:00 +02:00
Frantisek Sumsal
756ef1fa60 journal-remote: make MHD_OPTION_EXTERNAL_LOGGER the first option
To suppress a warning on journal-remote startup:
        systemd-journal-remote[691]: microhttpd:
        MHD_OPTION_EXTERNAL_LOGGER is not the first option specified for
        the daemon. Some messages may be printed by the standard MHD
        logger.
2023-06-19 23:42:00 +02:00
Frantisek Sumsal
84a6c2ba93 journal-remote: minor cleanups 2023-06-19 23:42:00 +02:00
Frantisek Sumsal
3c67c8bd4c journal-remote: simplify error handling a bit 2023-06-19 23:42:00 +02:00
Frantisek Sumsal
3f38d582d5 test: cover systemd-journal-remote --url=... 2023-06-19 23:42:00 +02:00
Zbigniew Jędrzejewski-Szmek
72e7bfe02d
Merge pull request #27941 from cvlc12/early_cpio
Define 'microcode' file type for the kernel-install staging area.
2023-06-19 18:49:31 +02:00
msizanoen
996b00ede8 Revert "core/service: when resetting PID also reset known flag"
This reverts commit ff32060f2e.

This change is incorrect as we don't want to mark the PID as invalid but
only mark it as dead.

The change in question also breaks user level socket activation for
`podman.service` as the termination of the main `podman system service`
process is not properly handled, causing any application accessing the
socket to hang.

This is because the user-level `podman.service` unit also hosts two
non-main processes: `rootlessport` and `rootlessport-child` which causes
the `cgroup_good` check to still succeed.

The original submitter of this commit is recommended to find another
more correct way to fix the cgroupsv1 issue on CentOS 8.
2023-06-19 18:18:46 +02:00
cvlc12
4221065237 Add docs, improve log comments. 2023-06-19 17:34:53 +02:00
Frantisek Sumsal
ed8f65c729
Merge pull request #28078 from keszybz/trivial-syntax-and-wording-fixes
Trivial syntax and wording fixes
2023-06-19 16:41:16 +02:00
Lennart Poettering
ab93429dea
Merge pull request #28056 from dtardon/polkit-cleanup
Some bus-polkit cleanup
2023-06-19 15:50:35 +02:00
Lennart Poettering
5cbfbf2aaa man: place options in a some limited form of subsections
Let's visually separate the options associated with cpu, io, memory, …
in subsections

This patch tries to be minimal. It just adds the section titles, and
does minimal reordering to make sure the options on the same kind of
resource are placed close to each other.
2023-06-19 13:42:34 +02:00
Zbigniew Jędrzejewski-Szmek
b2544bb6e8 machinectl: fix message
bus_wait_for_jobs_new() can fail for various reasons.
2023-06-19 13:36:30 +02:00
Zbigniew Jędrzejewski-Szmek
12cc960163 shared: improve messages about switch root operations
"change" is not clear without context.
2023-06-19 13:36:30 +02:00
Zbigniew Jędrzejewski-Szmek
730bdfed81 man/systemd-nspawn: fix indentation and parenthesis location 2023-06-19 13:36:30 +02:00
Zbigniew Jędrzejewski-Szmek
5811490a3f docs/CREDENTIALS: fix confusion of i.e. and e.g. 2023-06-19 13:36:30 +02:00
Zbigniew Jędrzejewski-Szmek
966dd7527d man: missing/misplaced periods 2023-06-19 13:36:30 +02:00
Sam Morris
d9714fe405
Resource control manpage fixup (#28046)
The order of the description of each item should match the order that they are declared. Un-document effect of deprecated non-unified CGroup hierarchy on
DefaultCPUAccounting=. Mention that the default value for DefaultCPUAccouting= is 
affected by the kernel version.
2023-06-19 13:30:43 +02:00
Luca Boccassi
14cb29dfd5
Merge pull request #28074 from mrc0mmand/journal-gatewayd-followups
A couple of follow-ups for systemd-journal-gatewayd tests
2023-06-19 12:14:28 +01:00
David Tardon
3a3d4d3bd8 bus-polkit: put function params to a single line 2023-06-19 12:36:40 +02:00
David Tardon
f8636446be bus-polkit: drop unnecessary else 2023-06-19 12:36:40 +02:00
David Tardon
4d12d3976c bus-polkit: merge variable declarations 2023-06-19 12:34:27 +02:00
David Tardon
d32ac157ef bus-polkit: decrease indentation 2023-06-19 12:33:24 +02:00
David Tardon
9f657af4c3 bus-polkit: extract creation of polkit call to a function 2023-06-19 12:32:40 +02:00
David Tardon
d2c50a176d bus-polkit: move verification to a separate function 2023-06-19 12:32:26 +02:00
Gibeom Gwon
5bfc4de634 homework: resize to maximum disk space if disk size is not specified
If the backing storage is LUKS2 on a block device, auto resize mode
is enabled, and disk size is not specified, resize the partition to
the maximum expandable size.

Fixes: #22255, #23967
2023-06-19 12:26:34 +02:00
Lennart Poettering
be76bf625c update TODO 2023-06-19 10:36:42 +02:00
Daan De Meyer
94c357ca23 mkosi: Update to latest
We now run repart before starting systemd-nspawn to make sure that
the root partition is also generated when we boot the image in a
container instead of a VM.

To make sure we start from scratch for both the container boot and
the VM boot, we also enable Ephemeral to make sure all changes to
the image are ephemeral.
2023-06-19 10:30:39 +02:00
Frantisek Sumsal
033601b79a test: wrap curl when running with ASan
Necessary (unfortunately) for curl on C8S.
2023-06-19 10:19:44 +02:00
Frantisek Sumsal
f9d1806e3b journal-gatewayd: handle SIGTERM
To allow gatewayd to exit cleanly.
2023-06-19 10:19:44 +02:00
licunlong
a068eeac6f core/dbus-manager: also show DefaultIOAccounting and DefaultIPAccounting
fix: https://github.com/systemd/systemd/issues/28045
2023-06-19 09:57:11 +02:00
Frantisek Sumsal
52db3601bd test: extend the DynamicUser=yes coverage workaround to a couple more services 2023-06-18 23:08:24 +02:00
cvlc12
a6d8884120 Define 'microcode' type of initrd for the kernel-install staging area.
This allows microcode to be referenced first for UKIs and loader entries.
2023-06-18 20:38:20 +02:00
Luca Boccassi
5f655ffb15
Merge pull request #28069 from medhefgo/boot-dp
boot: device_path_to_str improvements
2023-06-18 15:11:49 +01:00
Luca Boccassi
40cdb3b756 journal: avoid infinite recursion when closing bad journal FD
When trying to log, if we fail we try to close the journal FD. If
it is bad, safe_close() will fail and assert, which will try to log,
which will fail, which will try to close the journal FD...
Infinite recursion looks very pretty live in gdb, but let's avoid
that by immediately invalidating the journal FD before closing it.
2023-06-18 12:31:53 +01:00
Jan Janssen
78fffdea37 boot: Improve device_path_to_str_internal()
The UEFI spec has a generic `Path` node representation that can be used
for device path nodes that are unknown. So we can use that instead of
giving up when we see a node other than FilePath.

This also simplifies the FilePath case by just using xasprintf(). The
code is really just a fallback for silly firmware that does not
implement EFI_DEVICE_PATH_TO_TEXT_PROTOCOL (looking at you, Apple).

The correctness of this was tested by round-tripping it through
EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL, which yielded an identical device
compared to our input path.
2023-06-18 11:13:09 +02:00
Jan Janssen
e53e5c0ac1 boot: Split log_hexdump() 2023-06-18 11:13:03 +02:00