Yu Watanabe
28c3428df0
network: adds missing strv_free()
...
Fixes oss-fuzz#11285.
2018-11-08 12:30:03 +09:00
Yu Watanabe
7a99f98b50
network: make config_parse_radv_search_domains() log error in dns_name_apply_idna()
2018-11-08 12:29:38 +09:00
Yu Watanabe
9f7d3db3ed
fuzz: add more testcases of already fixed issue about multiple netdev kind
...
This adds testcases of oss-fuzz#11286, oss-fuzz#11287, oss-fuzz#11296,
oss-fuzz#11297, and oss-fuzz#11299.
The issue was fixed by 62facba19a
.
2018-11-08 12:16:13 +09:00
Zbigniew Jędrzejewski-Szmek
e1b2d44366
Merge pull request #10670 from yuwata/oss-fuzz-netdev-fixes
...
network: ignore multiple assignment of netdev kind
2018-11-07 19:31:31 +01:00
Steven Allen
86cf4554ef
logind: fix compilation without utmp ( #10674 )
2018-11-07 17:29:21 +01:00
Jan Synacek
1432d2dbdf
ask-password: improve log message when inotify limit is reached
...
When inotify_add_watch() fails because of the inotify limit, errno is
set to ENOSPC and then gets shown to users as "No space left on device".
That is very confusing and requires in-depth knowledge of the C library.
Therefore, show user-friendly message when inotify limit is reached.
Fixes #6030 .
2018-11-07 15:48:43 +01:00
Zbigniew Jędrzejewski-Szmek
e44c5a3ba6
Merge pull request #10594 from poettering/env-reload-fix
...
change handling of environment block of PID1's manager object
2018-11-07 12:49:13 +01:00
Zbigniew Jędrzejewski-Szmek
e67813dde0
Merge pull request #10610 from yuwata/udev-rules-cleanups
...
udev-rules: replace udev_device by sd_device
2018-11-07 11:34:33 +01:00
Yu Watanabe
1909e9f11d
network: drop unused members in Wireguard object
2018-11-07 18:14:11 +09:00
Yu Watanabe
348784e62a
fuzz: add testcases for oss-fuzz#11279 and #11280
2018-11-07 17:24:41 +09:00
Yu Watanabe
62facba19a
network: ignore multiple assignment of netdev kind
...
Fixes oss-fuzz#11279 and oss-fuzz#11280.
2018-11-07 17:23:50 +09:00
Yu Watanabe
11d93952ea
test: missing "die"
...
Follow-up for a41ff38b09
.
2018-11-07 08:57:28 +01:00
Evgeny Vereshchagin
44f7190c2d
Merge pull request #10668 from evverx/travis-tweaks
...
travis: build and run fuzzers against crash reproducers
2018-11-07 10:13:21 +03:00
Evgeny Vereshchagin
eeec5f2a69
travis: show all commands when building systemd
...
This should prevent Travis CI from terminating build jobs
that don't print anything for more than 10 minutes.
See https://travis-ci.org/systemd/systemd/builds/451737177 .
2018-11-07 07:49:50 +01:00
Evgeny Vereshchagin
b9abc93558
travis: build and run fuzzers against crash reproducers
2018-11-07 07:47:22 +01:00
Yu Watanabe
c6d8bbb66e
in-addr-util: make in_addr_default_prefix_from_string() or friend set 0 to prefixlen when family == AF_INET6 ( #10665 )
...
Follow-up for a4798d4e6d
.
Fixes #10662 .
2018-11-07 15:31:26 +09:00
Yu Watanabe
b74a0b6ae7
test: replace udev_device by sd_device in test-udev
2018-11-07 13:35:03 +09:00
Yu Watanabe
77ad202c72
udevadm-test: replace udev_device by sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
cf28ad4689
udev-event: make udev_event_new() take sd_device instead of udev_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
cf697ec00e
udev-rules: replace udev_device by sd_device in udev_rules_apply_to_event()
2018-11-07 13:35:03 +09:00
Yu Watanabe
dbea7f24d2
udev-rules: replace two udev_list_entry_foreach() by corresponding FOREACH_DEVICE_*() macros
2018-11-07 13:35:03 +09:00
Yu Watanabe
1017d66bf5
udev-rules: use structured initializer
2018-11-07 13:35:03 +09:00
Yu Watanabe
92b80c6baa
udev-rules: drop unused member file_list in struct udev_rules
2018-11-07 13:35:03 +09:00
Yu Watanabe
1ce7fecb4f
udev-rules: make import_parent_into_properties() take sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
13c7b75f2f
udev-rules: make import_file_into_properties() take sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
29b5eb5adf
udev-rules: make import_property_from_string() take sd_device
...
Also, this makes the function return negative errno, though its
return value is always ignored.
2018-11-07 13:35:03 +09:00
Yu Watanabe
f3d241feb2
udev: use sd_device for udev_event.dev_parent
2018-11-07 13:35:03 +09:00
Yu Watanabe
5ba7e79885
udev-rules: make match_attr() take sd_device instead of udev_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
480ecb7d28
udev: use sd_device for udev_event.dev_db
...
Also, this adds sd_device_unref for the object in udev_event_free()
for safety and readability of code.
2018-11-07 13:35:03 +09:00
Yu Watanabe
e0bb2ff94b
udev-event: make udev_event_new() take sd_netlink and take a reference of that
2018-11-07 13:35:03 +09:00
Yu Watanabe
0f86dc900e
udev-event: make udev_event_new() take exec_delay
2018-11-07 13:35:03 +09:00
Evgeny Vereshchagin
13d8a53aae
travis: make the directory with coverity tools available in a container
...
Otherwise `coverity.sh build` will fail with
```
find: '/var/tmp/coverity-scan-analysis': No such file or directory
```
See https://travis-ci.org/systemd/systemd/jobs/451683385 .
2018-11-07 07:19:51 +03:00
imayoda
844df810b8
hwdb: IdeaPad Miix 310 with another bios version ( #10661 )
...
another bios version for same model with portrait screen.
2018-11-07 12:59:24 +09:00
Evgeny Vereshchagin
bd2125031b
Merge pull request #10644 from mrc0mmand/travis-fix
...
Fix & re-enable Travis CI
2018-11-07 05:11:02 +03:00
Evgeny Vereshchagin
9608a59449
travis: overwrite test-capability with a simple script that is just skipped
...
so that it will be possible to work on the test failure and try to make
Travis CI work at the same time.
2018-11-07 02:55:07 +01:00
Yu Watanabe
5176b272ea
Merge pull request #10640 from evverx/networkd-fuzzers
...
Add a couple of fuzzers for network_load_one and netdev_load_one
2018-11-07 08:50:25 +09:00
Frantisek Sumsal
532a92fbdf
travis: workaround for dnf upgrade
...
dnf upgrade on Fedora Rawhide pulls in unwanted selinux-policy
packages which breaks the system in several ways (and usually
ends up with crashed systemd)
2018-11-06 21:09:45 +01:00
Evgeny Vereshchagin
3ff074bd85
oss-fuzz.sh: copy dictionaries along with "options" files
...
We currently don't have any upstream but it doesn't mean that
it should be impossible to experiment with local ones :-)
2018-11-06 19:55:11 +01:00
Evgeny Vereshchagin
220fa139de
tests: add a couple of files containing all the sections and directives
...
This should help the fuzzers to discover code paths faster.
In case anyone is interested, they were generated with the following script
```
perl -aF'/[\s,]+/' -ne '
if (my ($s, $d) = ($F[0] =~ /^([^\s\.]+)\.([^\s\.]+)$/)) { $d{$s}{$d} = 1; }
END { while (my ($key, $value) = each %d) {
printf "[%s]\n%s\n", $key, join("\n", keys(%$value))
}}'
```
by passing src/network/networkd-network-gperf.gperf and
src/network/netdev/netdev-gperf.gperf to it.
2018-11-06 19:42:29 +01:00
Evgeny Vereshchagin
cf02fd1b7a
tests: replace AdActorSysPrio with AdActorSystemPriority
...
This is a follow-up to https://github.com/systemd/systemd/pull/10653 .
2018-11-06 19:36:40 +01:00
Evgeny Vereshchagin
d0f51aa9cd
tests: add a reporoducer for https://github.com/systemd/systemd/issues/10639
2018-11-06 19:01:32 +01:00
Evgeny Vereshchagin
efc1a59af6
tests: add some data that can be fed to fuzz-network-parser
2018-11-06 19:01:32 +01:00
Evgeny Vereshchagin
a633d5b997
tests: add a reproducer for https://github.com/systemd/systemd/issues/10629
2018-11-06 19:01:32 +01:00
Evgeny Vereshchagin
212bd73c78
networkd: make network_load_one "public" and add a fuzzer for it
2018-11-06 19:01:32 +01:00
Evgeny Vereshchagin
e27aac11f2
networkd: make netdev_load_one "public" and add a fuzzer for it
2018-11-06 19:01:32 +01:00
Evgeny Vereshchagin
0621f03b13
networkd: remove a weird assertion from network_load_one
...
The assertion was added in dbffab87f1
but I'm not exactly sure
why. Now it just crashes a fuzzer I wrote. I, of course, could fix the fuzzer
so that it would generate names ending in ".network" if anyone would tell
me why the assertion should be kept here.
2018-11-06 19:01:32 +01:00
Evgeny Vereshchagin
3e180a2516
util: initialize _argtypes in VA_FORMAT_ADVANCE when systemd is built with MSan
...
This gets around https://github.com/google/sanitizers/issues/992 .
2018-11-06 19:01:32 +01:00
Yu Watanabe
49a060aca8
Merge pull request #10654 from poettering/srand-rdrand
...
random-util.c mini-fixes
2018-11-07 02:03:09 +09:00
Marco Trevisan (Treviño)
6260d28b8a
login: Don't mark framebuffer devices as master-of-seat devices
...
Currently we consider any framebuffer device as enough to have a
valid graphical session, but this might lead to many false postives
like in the case of framebuffer devices that have a linked drm card
which is still in the process of being added, or for vesa fb, and
so it doesn't ensure us that we can have a proper graphical session.
Since these days we normally don't consider anything without a DRM
card able to provide a full graphical session, let's not set this
at this level.
Drivers which can provide a graphical session with the sole fb are
still free to mark any device as `master-of-seat`
Fixes #10435
2018-11-06 20:02:26 +03:00
Lennart Poettering
39adc47495
Merge pull request #10658 from yuwata/udevd-worker-performance
...
udev: improve performance
2018-11-06 20:01:37 +03:00