8 Commits

Author	SHA1	Message	Date
Frantisek Sumsal	84031b5d6e	test: bunch of assorted tweaks to make shellcheck happy	2021-04-13 19:14:35 +02:00
Frantisek Sumsal	084575ff91	test: use set -eux and set -o pipefail everywhere ... This should make the scripts more robust.	2021-04-13 12:08:01 +02:00
Zbigniew Jędrzejewski-Szmek	0ee994836c	TEST-*: use spacing before redirection operator, but not after ... << EOF → <<EOF > foo < bar → >foo <bar	2021-04-08 20:21:50 +02:00
Zbigniew Jędrzejewski-Szmek	4e20fe2795	TEST-*: make failure tests actually fail on failure ... Here the intent was actually correct, and the tests still pass when the check is made effective.	2021-04-08 20:21:50 +02:00
Zbigniew Jędrzejewski-Szmek	ffa328f060	tests: make inverted tests actually count ... "! test ..." does not cause the script to fail, even with set -e. IIUC, bash treats this command as part of an expression line, as it would if 'test ... && ...' was used. Failing expression lines do not terminate the script. This fixes the obvious cases by changing '! test' → 'test !'. Then the inversion happens internally in test and bash will propagate the failure.	2021-04-08 11:45:59 +02:00
Frantisek Sumsal	86b52a3958	tree-wide: fix spelling errors ... Based on a report from Fossies.org using Codespell. Followup to #15436	2020-04-21 23:21:08 +02:00
Zbigniew Jędrzejewski-Szmek	68e2dc0f91	test/TEST-25: remove all images at the end of the test ... scratch5 would be left behind, and trying to run the test again on the same image would fail.	2020-03-28 11:46:47 +01:00
Zbigniew Jędrzejewski-Szmek	6e796683df	test: move TEST-25-IMPORT setup to static files ... Also run mask_supporting_services() here.	2020-03-28 11:46:47 +01:00