3 Commits

Author	SHA1	Message	Date
Zbigniew Jędrzejewski-Szmek	b88ba6c761	tmpfiles: make handling of existing-but-different targets more consistent ... create_fifo() was added in a2fc2f8dd3, and would always ignore failure. The test was trying to fail in this case, but we actually don't fail, which seems to be correct. We didn't notice before because the test was ineffective. To make things consistent, generally log at warning level, but don't propagate the error. For symlinks, log at debug level, as before. For 'e', failure is not propagated now. The test is adjusted to match. I think warning is appropriate in most cases: we do not expect a device node to be replaced by a different device node or even a non-device file. This would most likely be an error somewhere. An exception is made for symlinks, which are mismatched on purpose, for example /etc/resolv.conf. With this patch, we don't get any warnings with the any of the 74 tmpfiles.d files, which suggests that increasing the warning levels will not cause too many unexpected warnings. If it turns out that there are valid cases where people have expected mismatches for non-symlink types, we can always decrease the log levels again.	2021-04-08 20:16:37 +02:00
Zbigniew Jędrzejewski-Szmek	ffa328f060	tests: make inverted tests actually count ... "! test ..." does not cause the script to fail, even with set -e. IIUC, bash treats this command as part of an expression line, as it would if 'test ... && ...' was used. Failing expression lines do not terminate the script. This fixes the obvious cases by changing '! test' → 'test !'. Then the inversion happens internally in test and bash will propagate the failure.	2021-04-08 11:45:59 +02:00
Zbigniew Jędrzejewski-Szmek	c0b97b0fc8	test: move TEST-22-TMPFILES setup to static files	2020-03-28 11:46:47 +01:00