1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-13 23:21:08 +03:00
Commit Graph

22679 Commits

Author SHA1 Message Date
Lennart Poettering
42718282f5 update TODO 2015-10-07 21:38:29 +02:00
Lennart Poettering
ae3dde8012 machinectl: fix race when opening new shells with "machinectl shell"
Previously, we'd allocate the TTY, spawn a service on it, but
immediately start processing the TTY and forwarding it to whatever the
commnd was started on. This is however problematic, as the TTY might get
actually opened only much later by the service. We'll hence first get
EIOs on the master as the other side is still closed, and hence
considered it hung up and terminated the session.

With this change we add a flag to the pty forwarding logic:
PTY_FORWARD_IGNORE_INITIAL_VHANGUP. If set, we'll ignore all hangups
(i.e. EIOs) on the master PTY until the first byte is successfully read.
From that point on we consider a hangup/EIO a regular connection termination. This
way, we handle the race: when we get EIO initially we'll ignore it,
until the connection is properly set up, at which time we start
honouring it.
2015-10-07 20:10:48 +02:00
Lennart Poettering
660021d371 util: always enforce O_NOCTTY and O_CLOEXEC in openpt_in_namespace()
The child process is shortliving, hence always set O_NOCTTY so that the
tty doesn't quickly become controlling TTY and then gives it up again.
Also set O_CLOEXEC, because it's cleaner, and doesn't affect the parent
anyway.
2015-10-07 20:08:49 +02:00
Lennart Poettering
c379f143a5 build-sys: bump library version 2015-10-07 17:06:22 +02:00
Lennart Poettering
24645b333d build-sys: add sd_listen_fds_with_name() to .sym file 2015-10-07 17:04:39 +02:00
Daniel Mack
44f169accf configure.ac: bump version number 2015-10-07 16:39:59 +02:00
Daniel Mack
1e0adaa45d update NEWS 2015-10-07 16:00:38 +02:00
Daniel Mack
bdba9227ec NEWS: re-order entries slightly
Also, the release is actually done in Berlin ;)
2015-10-07 15:57:04 +02:00
Lennart Poettering
61e6771c4a Update NEWS 2015-10-07 15:48:58 +02:00
Lennart Poettering
b1b533a060 analyze: trivial code cleanups 2015-10-07 15:45:39 +02:00
Lennart Poettering
c30f086f04 update NEWS 2015-10-07 15:45:39 +02:00
Daniel Mack
79bec997c9 Merge pull request #1484 from poettering/ask-pass-kernel-keyring
cache harddisk passwords in the kernel keyring
2015-10-07 15:32:42 +02:00
Lennart Poettering
f74431288a Merge pull request #1485 from jsynacek/machine-long-filename-v5
import: hash URL in paths if they are too long
2015-10-07 15:59:51 +03:00
Lennart Poettering
5530caa20b Merge pull request #1487 from michich/fix-env-expansion
Fix env expansion
2015-10-07 15:54:04 +03:00
Lennart Poettering
7c85ab42dd Merge pull request #1486 from michich/crash-handler
core: crash handler changes, CrashChangeVT parsing fix
2015-10-07 15:53:21 +03:00
Michal Schmidt
3faf145d32 man: fix typo ('and' -> 'are') 2015-10-07 14:45:11 +02:00
Michal Schmidt
df553b586b basic: fix env expansion for strings leading with two dollar signs
The way to escape a literal dollar sign is to write "$$". But this does
not work right if it's at the beginning of the argument. Fix it.
2015-10-07 14:43:55 +02:00
Michal Schmidt
7d06dad900 core: always let the kernel reap zombies when we're about to freeze
Regardless of whether we're going to spawn a crash shell or not, let the
kernel reap zombies. It's more consistent this way.
2015-10-07 14:25:51 +02:00
Michal Schmidt
4cf0b03b97 core: change how crash_shell and crash_reboot interact
Instead of freezing in PID1 and letting the forked child freeze or
reboot when exec("/bin/sh") fails, just wait for the child's
exit and then do the freeze_or_reboot in PID1 as usual.

This means that when both crash_shell and crash_reboot are enabled, the
system will reboot after the shell exits.
2015-10-07 14:24:49 +02:00
Michal Schmidt
647cb08bc3 core: remove spurious assert in parsing CrashChangeVT=
"data" is always NULL (and unused) in config_parse_crash_chvt().
2015-10-07 14:24:49 +02:00
Jan Synacek
9818005de6 import: hash URL in paths if they are too long
https://bugzilla.redhat.com/show_bug.cgi?id=1266775
2015-10-07 14:06:49 +02:00
Michal Schmidt
f7cd3d5fcb core: adjust error message about /etc/mtab
Since having /etc/mtab as a regular file is now a fatal error, stop
mentioning irrelevant minor consequences.
2015-10-07 13:08:05 +02:00
Lennart Poettering
e287086b8a ask-password: add support for caching passwords in the kernel keyring
This adds support for caching harddisk passwords in the kernel keyring
if it is available, thus supporting caching without Plymouth being
around.

This is also useful for hooking up "gdm-auto-login" with the collected
boot-time harddisk password, in order to support gnome keyring
passphrase unlocking via the HDD password, if it is the same.

Any passwords added to the kernel keyring this way have a timeout of
2.5min at which time they are purged from the kernel.
2015-10-07 12:26:14 +02:00
Daniel Mack
42911a567d Merge pull request #1481 from again4you/devel/smack_sysuser_#4
smack: label /etc/passwd and friends as '_' smack label when --with-smack-run-label' is enabled (v3)
2015-10-07 11:37:21 +02:00
Daniel Mack
064d3eb5a5 Merge pull request #1478 from steelman/analyze-without-hostnamed-fix
analyze: minor fixes according to review
2015-10-07 11:36:29 +02:00
Daniel Mack
dc086b5430 Merge pull request #1483 from reverendhomer/patch-2
service: fix memory leak in service_add_fd_store()
2015-10-07 11:18:27 +02:00
Daniel Mack
a99bbbdc0b Merge pull request #1482 from reverendhomer/patch-1
strv: fix infinite loop in strv_extend_n()
2015-10-07 11:16:08 +02:00
reverendhomer
17dec0f703 service: fix memory leak in service_add_fd_store()
fixes Coverity #1325767
2015-10-07 11:55:31 +03:00
reverendhomer
6fff8ac4a9 strv: fix infinite loop in strv_extend_n()
Fixes Coverity #1325768
2015-10-07 11:52:10 +03:00
Sangjung Woo
c02e7b1ecc smack: label /etc/passwd and friends as '_' smack label when --with-smack-run-label' is enabled
systemd-sysusers.service unit creates system users and groups and it
could update /etc/passwd, /etc/group, /etc/shadow and /etc/gshadow.
Those files should have '_' smack label because of accessibility.

However, if systemd has its own smack label using '--with-smack-run-label'
configuration, systemd-sysusers process spawned by systemd(pid:1) has
its parent smack label and eventually updated files also is set as its
parent smack label.

This patch fixes that bug by labeling updated files as '_' smack label
when --with-smack-run-label' is enabled.
2015-10-07 16:37:25 +09:00
Łukasz Stelmach
febda62a36 analyze: minor fixes according to review
+ use _cleanup_host_info in acquire_host_info()

+ revert the first strempty() to show "Linux" string in case
  os_pretty_name is missing.
2015-10-07 08:02:31 +02:00
Daniel Mack
69b8a8ebae Merge pull request #1475 from steelman/analyze-without-hostnamed
Analyze without hostnamed [V3]
2015-10-06 18:23:02 +02:00
Daniel Mack
ac773fd8d5 Merge pull request #1474 from teg/siphash24
siphash: style fixes
2015-10-06 18:12:25 +02:00
Łukasz Stelmach
caeacefe9f analyze: replace isempty()+ternary with strempty() 2015-10-06 17:56:19 +02:00
Łukasz Stelmach
6cdf0399f3 analyze: do not require information from hostnamed 2015-10-06 17:56:19 +02:00
Łukasz Stelmach
19f462f2de analyze: introduce _cleanup_host_info_ 2015-10-06 17:56:12 +02:00
Tom Gundersen
17010c230e siphash24: coding-style fixes
Drop custom types. Drop unnecessary macros. Fix whitespace. Add asserts.
2015-10-06 17:47:00 +02:00
Tom Gundersen
0cb3c28688 siphash24: unify API
Make the API of the new helpers more similar to the old wrapper.

In particular we now return the hash as a byte string to avoid
any endianness problems.
2015-10-06 17:47:00 +02:00
Lennart Poettering
0084360296 ask-password: various modernizations
Primarily clean-up error logging: log either all or no error messages in
the various functions. Mostly this means the actual password querying
calls no longer will log on their own, but the callers have to do so.

Contains various other fixes too, for example ports some code over to
use the clean-up macro.

Should contain no functional changes.
2015-10-06 16:27:24 +02:00
Lennart Poettering
8c60d978bd Merge pull request #1473 from michich/test-hashmap
test: hashmap - increase number of entries for crippled hash test
2015-10-06 17:18:20 +03:00
Lennart Poettering
c7ddad5148 update CODING_STYLE 2015-10-06 15:52:03 +02:00
Daniel Mack
13af9152bc Merge pull request #1469 from poettering/even-more-fixed
Even more fixes
2015-10-06 14:59:24 +02:00
Michal Schmidt
11de3decc9 test: hashmap - increase number of entries for crippled hash test
The purpose of testing with the crippled hash function is to cover
the otherwise very unlikely codepath in bucket_calculate_dib() where
it has to fall back to recomputing the hash value.

This unlikely path was not covered by test-hashmap anymore after
57217c8f "test: hashmap - cripple the hash function by truncating the
input rather than the output".

Restore the test coverage by increasing the number of entries in the test.
The number was determined empirically by checking with lcov.
2015-10-06 14:56:33 +02:00
Lennart Poettering
20d2f7851a Merge pull request #1465 from teg/siphash24
hashmap/siphash24: refactor hash functions
2015-10-06 14:02:10 +03:00
Lennart Poettering
d046fb9366 update NEWS 2015-10-06 12:33:25 +02:00
Lennart Poettering
0a3bb96e2c util: some comment fixes in fdname_is_valid() 2015-10-06 12:33:14 +02:00
Lennart Poettering
5b70037083 strv: properly return ENOMEM where we should in strv_extend_n() 2015-10-06 12:32:50 +02:00
Lennart Poettering
163c76c930 activate: validate fdname when accepting it 2015-10-06 12:32:31 +02:00
Lennart Poettering
ba6bfc0d75 man: use <function> where we refer to functions 2015-10-06 12:32:15 +02:00
Tom Gundersen
c48eb61fa7 NEWS 2015-10-06 12:11:44 +02:00