1
0
mirror of https://github.com/systemd/systemd.git synced 2024-10-30 06:25:37 +03:00
Commit Graph

40434 Commits

Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek
8f5d6a044b
Merge pull request #12619 from zachsmith/refactor-parse-sleep-config
systemd-sleep: refactor sleep conf parsing
2019-06-03 17:30:05 +02:00
Joe Richey
f8e54bf319 sd-boot: Remove unnecessary call to GetEventLog
This PR reverts #4302 and part of #7568, as the call to GetEventLog
isn't necessary to get the logs from the OS runtime.

This has already been reverted in shim, see:
    fd7c3bd920

The reasoning for the change that added this is wrong, explained below:

> According to TCG EFI Protocol Specification for TPM 2.0 family,
> all events generated after the invocation of EFI_TCG2_GET_EVENT_LOG
> shall be stored in an instance of an EFI_CONFIGURATION_TABLE aka
> EFI TCG 2.0 final events table.

This is correct and a valid reading of the TCG spec.

> Hence, it is necessary to trigger the internal switch through calling
> get_event_log() in order to allow to retrieve the logs from OS runtime.

However, this reasoning is incorrect. The "EFI TCG 2.0 final events
table" exists to allow the OS Runtime to get TCG events created during
or after the call to ExitBootServices. If systemd-boot didn't call
trigger_tcg2_final_events_table(), the call to HashLogExtendEvent will
write the event to the normal events table (i.e. the same place the
PCR 0 - 7 related events are written). Then the OS can obtain these
systemd-boot events in the same way it obtains normal events, via a
call to GetEventLog().

Tested on amd64 w/ TPM2 using the newest Linux kernel patches that
get the TPM2 formatted log:
    https://www.lkml.org/lkml/2019/5/20/1590
I confirmed that this change still lets the OS runtime obtain the log
entries created by systemd-boot.

Signed-off-by: Joe Richey <joerichey@google.com>
2019-06-03 15:47:09 +02:00
Zbigniew Jędrzejewski-Szmek
741c73c076
Merge pull request #12666 from yuwata/networkctl-show-stats
networkctl: show stats
2019-06-03 15:38:49 +02:00
Zbigniew Jędrzejewski-Szmek
2bb24885de
Merge pull request #12700 from yuwata/udev-propagate-critical-errors
udev: modernize code and propagate critical errors
2019-06-03 15:29:40 +02:00
Michal Sekletar
e7fca352ba execute: dump CPUAffinity as a range string instead of a list of CPUs
We do this already when printing the property in systemctl so be
consistent and do the same for systemd-analyze dump.
2019-06-03 15:21:52 +02:00
Yu Watanabe
81914d9f13 networkctl: drop unnecessary use of table_add_cell_full() 2019-06-03 16:43:18 +09:00
Yu Watanabe
d7aee41db3 udev: check formatting of attribute or value earlier 2019-06-03 08:35:33 +09:00
Yu Watanabe
1448820aad udev: evaluate formatting in RUN= key earlier
Closes #12291.
2019-06-03 08:35:33 +09:00
Yu Watanabe
7280153364 udev: use delete_trailing_chars() at one more place 2019-06-03 08:35:33 +09:00
Yu Watanabe
1b65f1ebc3 udev: replace xsprintf() + strpcpy() by strpcpyf() 2019-06-03 08:35:33 +09:00
Yu Watanabe
ce4f94b8e9 udev: make parser for attribute of $result harder 2019-06-03 08:35:33 +09:00
Yu Watanabe
13cd553f91 udev: split udev_event_apply_format() into small pieces
Also, this makes the function refuse invalid formatting and
propagate error in substituing variable.
2019-06-03 08:35:08 +09:00
Yu Watanabe
3c209d6070 udev: comment that $tempnode and $sysfs formats are deprecated 2019-06-02 14:15:32 +09:00
Yu Watanabe
ef315adaa4 udev: pass format type to udev_event_subst_format() 2019-06-02 14:15:32 +09:00
Yu Watanabe
7e9c23dd19 udev: rename enum subst_type -> FormatSubstitutionType 2019-06-02 14:15:32 +09:00
Yu Watanabe
25de7aa7b9 udev: modernize udev-rules.c
This does the following:
- rename enum udev_builtin_cmd -> UdevBuiltinCmd
- rename struct udev_builtin -> UdevBuiltin
- move type definitions to udev-rules.h
- move prototypes of functions defined in udev-rules.c to udev-rules.h
- drop to use strbuf
- propagate critical errors in applying rules,
- drop limitation for number of tokens per line.
2019-06-02 14:15:26 +09:00
Yu Watanabe
335dd8ba13 networkctl: show link bit rates 2019-06-01 10:24:47 +09:00
Yu Watanabe
a879e1a46e network: monitor link bit rates 2019-06-01 10:24:47 +09:00
Yu Watanabe
94a58cc1f9 bash-completion: support --stats/-s option of networkctl 2019-06-01 10:24:47 +09:00
Yu Watanabe
a459b24f7e networkctl: optionally show link statistics 2019-06-01 10:24:47 +09:00
Yu Watanabe
c095e5b02b netlink: set attribute size of IFLA_STATS and IFLA_STATS64 2019-06-01 10:24:47 +09:00
Zbigniew Jędrzejewski-Szmek
90e29fe1a5 networkctl: shorten Minimum/Maximum to min/max
This makes the output slightly "lighter" visually. min/max are well-established
forms, so there's no risk of misunderstanding. Also, not using title-case looks
a bit better.

Follow-up for c06ff86e25.

$ build/networkctl status '*'|grep MTU
                   MTU: 65536
                   MTU: 1500 (min: 68, max: 9000)
                   MTU: 1500 (max: 2048)
                   MTU: 1500 (min: 256, max: 2304)
                   MTU: 1500 (min: 68, max: 65535)
                   MTU: 1500 (min: 68, max: 65521)
                   MTU: 1500 (min: 68, max: 65535)
                   MTU: 1500 (max: 65535)
                   MTU: 1360 (min: 68, max: 65535)
2019-06-01 10:24:08 +09:00
Michal Sekletar
75e40119a4 dbus-execute: make transfer of CPUAffinity endian safe (#12711)
We store the affinity mask in the native endian. However, over D-Bus we
must transfer the mask in little endian byte order.

This is the second part of c367f996f5.
2019-05-31 15:23:23 +02:00
Krayushkin Konstantin
aae3c9a075 coredump: fixed bug - some coredump temp files could be lost
If the machine was suddenly shutted down (hard reboot for example) while
processing core dump, temp files created manually (not with a O_TEMPFILE flag)
stay in the system. After reboot systemd-coredump treat them as usual files, so
they wouldn't be rotated and shall pollute the filesystem.

Solution is to simply add those temp files to systemd-tmpfiles configs.
2019-05-31 12:57:35 +02:00
Zbigniew Jędrzejewski-Szmek
79e68937d3
Merge pull request #12707 from yuwata/test-network-lsan-options
test-network: add --lsan-options option
2019-05-31 11:38:18 +02:00
Yu Watanabe
c06ff86e25 networkctl: do not show zero maximum MTU 2019-05-31 10:55:07 +02:00
Yu Watanabe
72917fcc65 test-network: show systemd-networkd.service
As there may exist some other drop-in configs.
2019-05-31 13:58:27 +09:00
Anita Zhang
b3d593673c core: add ExecStartXYZEx= with dbus support for executable prefixes
Closes #11654
2019-05-30 20:41:42 -07:00
Yu Watanabe
d4fda2a55c test-network: stop service before editing unit file 2019-05-31 09:52:48 +09:00
Yu Watanabe
fa4c6095d7 test-network: add --lsan-options option 2019-05-31 08:52:27 +09:00
Yu Watanabe
9e90465539
Merge pull request #12705 from keszybz/varlink-json-fix-and-two-cleanups
Varlink json fix and two cleanups
2019-05-31 08:28:37 +09:00
Zbigniew Jędrzejewski-Szmek
98d4a4dfb3 sd-journal: voidify call
To appease coverity, CID#1400674.
2019-05-30 23:05:31 +02:00
Zbigniew Jędrzejewski-Szmek
5043ec6476 networkd: shorter two error statements a bit
Also let's not use a cast if we don't have to.
2019-05-30 22:56:03 +02:00
Zbigniew Jędrzejewski-Szmek
3135369cff basic/memory-util: do not "return" anything from memzero() macro
The macro is not used in expressions, so we don't need the ternary statement.
2019-05-30 22:55:32 +02:00
Frantisek Sumsal
4eb5312079 systemctl: process all units matched by a glob in the cat verb by default
Originally, `systemctl cat` would match only active units, for example:

$ systemctl cat sshd.service

would cat the sshd.service unit file even if the service was inactive.
However:

$ systemctl cat ssh*

would show it only if it was active.

Let's unify the behavior and cat all unit files regardless of a state,
if no state was given explicitly to filter.
2019-05-30 21:11:44 +02:00
Zbigniew Jędrzejewski-Szmek
e7b93f97ed shared/varlink: add missing va_end()
Coverity CID#1401347.
2019-05-30 20:36:54 +02:00
Zbigniew Jędrzejewski-Szmek
a48481dc77 Revert "varlink: initialize Varlink with 0"
This reverts commit 8688c29b5a, but leaves the
reproducer. Structured assignment should be enough to fully initialize the
variable and new0 is not necessary.
2019-05-30 19:39:27 +02:00
Yu Watanabe
cfa0ce187f
Merge pull request #12699 from yuwata/test-network-argparse
test-network: make path to networkd or friends configurable
2019-05-31 02:33:10 +09:00
Zbigniew Jędrzejewski-Szmek
2a04712c19 shared/varlink: add missing terminator in json strings
Should finally fix oss-fuzz-14688.
8688c29b5a wasn't enough.

The buffer retrieved from memstream has the size that the same as the written
data. When we write do write(f, s, strlen(s)), then no terminating NUL is written,
and the buffer is not (necessarilly) a proper C string.
2019-05-30 18:45:06 +02:00
Zbigniew Jędrzejewski-Szmek
c2babfc2f5 networkd: rewrite condition to make it easier to understand 2019-05-30 15:31:44 +02:00
Zbigniew Jędrzejewski-Szmek
521ff2fcd0 test-user-util: add simple test for make_salt() 2019-05-30 15:31:44 +02:00
Zach Smith
7874583da3 systemd-sleep: (bug) honor s2h and hybrid_sleep disable settings 2019-05-30 06:08:02 -07:00
Zach Smith
28ca9c2499 systemd-sleep: refactor sleep config parsing
remove verb from parse

refactor required fields checks

refactor allow settings
2019-05-30 06:06:16 -07:00
Frantisek Sumsal
cec82cb943 bash-completion: correctly react to an unescaped unit name 2019-05-30 14:30:59 +02:00
Zbigniew Jędrzejewski-Szmek
665b0af866
Merge pull request #12636 from mbroz/master
Cryptsetup: call crypt_load() once for LUKS and support LUKS2 tokens
2019-05-30 14:27:22 +02:00
Yu Watanabe
7e4831d296 util: introduce strnpcpy() and strnscpy() 2019-05-30 21:08:51 +09:00
Yu Watanabe
961189af2a util: introduce PTR_TO_MODE and MODE_TO_PTR macros 2019-05-30 21:08:51 +09:00
Yu Watanabe
e2835111dd networkctl: fix memleak
Closes #12701.
2019-05-30 20:58:36 +09:00
Yu Watanabe
94c0312294 test-network: make the test take ASAN and UBSAN options 2019-05-30 20:51:35 +09:00
Yu Watanabe
9c1ae4844e test-network: make path to networkd or friends configurable 2019-05-30 20:49:56 +09:00