1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-08 11:27:32 +03:00
Commit Graph

7866 Commits

Author SHA1 Message Date
Lennart Poettering
18da49531e update TODO 2012-03-14 19:10:29 +01:00
Lennart Poettering
071fd8c21e journal: fix memory leak 2012-03-14 18:31:38 +01:00
Kay Sievers
91418155ae rules sort order: /lib, /run, /etc
After long consideration we came to the conclusion that user
configuration in /etc should always override the (generally
computer generated) configuration in /run. User configuration
should always be what matters over anything else. Hence rearrange
the search orders accordingly. In general this should change
very little as overriding like this is seldomn done so far,
and the order between /etc and /usr stays the same.
2012-03-14 18:10:59 +01:00
Marti Raudsepp
189f6d82ee journal: Don't hold pointers to journal while remapping
Hi!

I was trying out the journal and the journalctl utility sometimes
crashed on me. After some debugging, I tracked it down to the fact
that next_with_matches() holds the "c" object pointer through the
journal_file_next_entry_for_data() call -- which apparently may re-map
the journal file, invalidating the pointer.

The attached patch fixes this crash for me, but being unfamiliar with
the code, I don't know if I'm doing the right thing.

This patch is also available from my github repository:
git://github.com/intgr/systemd.git
https://github.com/intgr/systemd

Regards,
Marti

For the record, here's the original stack trace at the time of remapping:

ret=0x7fff1d5cdec0) at src/journal/journal-file.c:330
ret=0x7fff1d5cdf28) at src/journal/journal-file.c:414
ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at
src/journal/journal-file.c:1101
i=5705, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at
src/journal/journal-file.c:1147
p=6413608, data_offset=66600, direction=DIRECTION_DOWN,
ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at
src/journal/journal-file.c:1626
direction=DIRECTION_DOWN, ret=0x7fff1d5ce120, offset=0x7fff1d5ce128)
at src/journal/sd-journal.c:533
direction=DIRECTION_DOWN, ret=0x7fff1d5ce170, offset=0x7fff1d5ce178)
at src/journal/sd-journal.c:595
src/journal/sd-journal.c:651

From 9266fc6a58065a7c5dab67430fd78925e519dce9 Mon Sep 17 00:00:00 2001
From: Marti Raudsepp <marti@juffo.org>
Date: Fri, 9 Mar 2012 16:23:00 +0200
Subject: [PATCH] journal: Don't hold pointers to journal while remapping

This would cause a segfault otherwise.
2012-03-14 17:55:55 +01:00
Lennart Poettering
8af0fcdb90 update TODO 2012-03-14 17:23:43 +01:00
Lennart Poettering
17a949114d log: introduce log_metav 2012-03-14 14:54:41 +01:00
Lennart Poettering
0d1575814b update TODO 2012-03-14 14:37:49 +01:00
Lennart Poettering
9d648202eb pkg-config: bring unit search path order in sync with the code 2012-03-14 14:31:57 +01:00
Lennart Poettering
b412ab3bcc path-lookup: rearrange things so that the system path order follows the user path order 2012-03-14 14:31:50 +01:00
Lennart Poettering
fc1a2e06a2 conf: when looking for configurations look in /etc first, in /run second
After long consideration we came to the conclusion that user
configuration in /etc should always override the (generally computer
generated) configuration in /run. User configuration should always be
what matters over anything else. Hence rearrange the search orders
accordingly.

In general this should change very little as overriding like this is
seldomn done so far, and the order between /etc and /usr stays the same.
2012-03-14 14:25:05 +01:00
Lennart Poettering
45dc3a0478 man: document where we read kernel cmdline options from 2012-03-14 14:13:12 +01:00
Lennart Poettering
09b967eaa5 machine-id: initialize from $container_uuid if not set otherwise
This is a result of the discussions on

https://bugs.freedesktop.org/show_bug.cgi?id=46894
2012-03-14 14:06:42 +01:00
Lennart Poettering
2d44fc7ba5 journald: allocate PAGE_SIZE bytes for selinux label length
As suggested in https://bugzilla.redhat.com/show_bug.cgi?id=798760
2012-03-14 03:39:15 +01:00
Lennart Poettering
77b088c211 socket: make sure that the name for per-connection services are unique
If a client connects to us repeatedly always using the same source port
and we instantiate a service for the incoming connection this might
clash with an old instance. Hence, include the connection number, the
same way we do it for AF_UNIX to make connections unique.

https://bugs.freedesktop.org/show_bug.cgi?id=45297
2012-03-14 03:07:26 +01:00
Lennart Poettering
9586cdfab6 socket: if we fail to create an instantiated service for a socket, don't put the socket in failure mode
An incoming connection that is immediately terminated might result in
getpeername() or a similar call failing. Hence it is quite possible that
while we are setting up an instantiated service for a socket we might
get an error and we shouldn't take this as hint to take the listening
socket down.

https://bugs.freedesktop.org/show_bug.cgi?id=45297
https://bugzilla.novell.com/show_bug.cgi?id=741590
2012-03-14 03:01:27 +01:00
Kay Sievers
4b50a3d004 extras: ata_id - do not log error if HDIO_GET_IDENTITY fails
<tomegun> kay: is this a valid issue: https://bugs.archlinux.org/task/27060 ?
<kay> tomegun: udev does not really care if that fails
<tomegun> kay: the suggestion there is to treat EINVAL the same way we treat ENOTTY (i.e. as an info only)
<tomegun> if it really does not matter it might make sense to avoid bogus bug reports
<kay> tomegun: done
2012-03-14 01:01:16 +01:00
Lennart Poettering
6b80b9b8ee update TODO 2012-03-13 13:44:47 +01:00
Kay Sievers
746b5152cc extras: path_id - add comment about readdir() rebase logic 2012-03-13 12:55:53 +01:00
Lennart Poettering
9631c090fd mount: fix assertion
https://bugzilla.redhat.com/show_bug.cgi?id=768523
2012-03-13 03:34:42 +01:00
Lennart Poettering
62f168a05b conf-parser: warn if an assignment is place outside of a section
https://bugzilla.redhat.com/show_bug.cgi?id=783134
2012-03-13 02:41:29 +01:00
Lennart Poettering
b19be9eb9e util: add brute-force fallback for close_all_fds()
If /proc is not available (i.e. in chroot envs) let's fall back to brute
forcing our way through the fd table.

https://bugzilla.redhat.com/show_bug.cgi?id=784921
2012-03-13 02:29:27 +01:00
Lennart Poettering
7f2c63cbf4 journald: use SCM_SECURITY to race-freely determine peer SELinux label
https://bugzilla.redhat.com/show_bug.cgi?id=798760
2012-03-13 02:29:10 +01:00
Lennart Poettering
54ecda32c6 socket: add option for SO_PASSEC
https://bugzilla.redhat.com/show_bug.cgi?id=798760

(Note that this work is not complete yet, as the kernel seems to send us
useless data with SCM_SECURITY enabled)
2012-03-13 00:00:27 +01:00
Shawn Landden
fa734f4da8 login: tag the Mimo 720 ID_AUTOSEAT
This device is a combination USB hub, displaylink graphics, and e2i touchscreen

Bus 001 Device 005: ID 058f:6254 Alcor Micro Corp. USB Hub
Bus 001 Device 006: ID 17e9:401a Newnham Research
Bus 001 Device 007: ID 1ac7:0001

|__ Port 1: Dev 5, If 0, Class=hub, Driver=hub/4p, 480M
    |__ Port 2: Dev 6, If 0, Class=vend., Driver=udlfb, 480M
    |__ Port 2: Dev 6, If 1, Class=HID, Driver=usbhid, 480M
    |__ Port 3: Dev 7, If 0, Class=vend., Driver=usbtouchscreen, 12M
2012-03-12 22:49:14 +01:00
Matthew Garrett
3bfc7a97b1 rules: Enable USB autosuspend on more USB HID devices
Many servers will be connected to KVMs or include iLO support, and this
is often presented as a set of USB input devices. Enabling autosuspend on
these allows the USB hardware to be powered down, avoiding unnecessary
wakeups and power consumption. The input devices will be self powered, so
there's no risk of losing input events as there would be for real input
devices. The same is true of USB input devices that are built into the
system.
2012-03-12 22:40:40 +01:00
Lennart Poettering
7f110ff9b8 conf: enforce UTF8 validty everywhere
we need to make sure that configuration data we expose via the bus ends
up in using getting an assert(). Even though configuration data is only
parsed from trusted sources we should be more careful with what we read.
2012-03-12 22:22:21 +01:00
Lennart Poettering
669e49fe2c man: reword tmpfiles selinux bits 2012-03-12 21:51:39 +01:00
Kay Sievers
481dcf7c8f extras: path_id - skip ATA transport class devices 2012-03-12 18:40:23 +01:00
Lennart Poettering
8d2831af71 update TODO 2012-03-12 14:01:27 +01:00
Kay Sievers
8e90942c7a rules: move all rules to top level rules/ dir 2012-03-07 18:01:27 +01:00
Kay Sievers
d0066c7416 update TODO 2012-03-07 17:55:30 +01:00
Kay Sievers
64f7fb8b1e rules: delete s390 rules, they will move to s390utils 2012-03-07 17:54:53 +01:00
Kay Sievers
1bb8c5351a build-sys: remove empty directory 2012-03-07 17:22:29 +01:00
Kay Sievers
4774868cca remove edd_id extra
The use of identifying disks by magic byte sequences outside of the
filesystem or partion table is fragile and usually creates more
problems than it solves.
2012-03-07 17:16:21 +01:00
Kay Sievers
df4554c333 rules: move 42-qemu-usb.rules to rules/ dir 2012-03-07 17:12:15 +01:00
Kay Sievers
96ca373628 rules: delete outdated 30-kernel-compat.rules 2012-03-07 17:10:26 +01:00
Kay Sievers
6997e3b2dc move src/extras subdirectories to src/ 2012-03-07 17:03:48 +01:00
Kay Sievers
4683a5fa06 udev.conf - do not set any value by default 2012-03-07 16:38:02 +01:00
Kay Sievers
b618e9957b remove udev-acl
Udev-acl will be part of a future ConsoleKit release. On systemd systems,
advanced ConsoleKit and udev-acl functionality are natively provided by
systemd.
2012-03-07 16:34:56 +01:00
Lennart Poettering
03f38e7498 man: clarify that applications must ignore unknown fields 2012-03-06 18:17:07 +01:00
Lennart Poettering
edcf3b8900 man: document how os-release(5) may be extended by OS vendors 2012-03-06 18:14:06 +01:00
Lennart Poettering
d383ac0d2f man: fix typo 2012-03-06 17:58:27 +01:00
Lennart Poettering
74bebb314b man: allow that /etc/os-release is a symlink 2012-03-06 17:52:21 +01:00
Lennart Poettering
62ca938d2d man: add URL field definitions to os-release(5)
As requested by Raphaël Hertzog from the Debian project, include
information about the home page and support/bug report pages in
/etc/os-release.
2012-03-06 17:44:32 +01:00
Lennart Poettering
e21aee1494 man: add ID_LIKE definition to os-release(5)
As requested by Raphaël Hertzog from the Debian project, encode
derivative information in /etc/os-release.
2012-03-06 13:59:12 +01:00
Lennart Poettering
93e487fc8f update TODO 2012-03-06 12:55:57 +01:00
Lennart Poettering
48496df65c journal: make sure to refresh window position and pointer after we linked up a data object 2012-03-06 02:42:32 +01:00
Dave Reisner
85eda5721f mount: properly check return for mount_add_*
Previously, mount_load_etc_fstab() could never fail for reasons other
than a setmntent() or allocation failure.
2012-03-06 02:16:41 +01:00
Harald Hoyer
e2e9329411 bash-completion: get rid of awk, sed and grep
Get rid of "awk", "sed" and "grep" calls.
This can be done entirely in bash!

With help from Dave Reisner
2012-03-06 02:11:01 +01:00
Lennart Poettering
52af21063b nspawn: be less cryptic when clone() fails
Based on a patch suggested by Shawn Landden.
2012-03-06 02:06:29 +01:00