1
0
mirror of https://github.com/systemd/systemd.git synced 2024-10-28 20:25:38 +03:00
Commit Graph

13974 Commits

Author SHA1 Message Date
Michael Scherer
2047a15a17 Fix format string mismatch introduced in ab9001a1
src/libsystemd-bus/sd-bus.c: In function 'sd_bus_open_user':
src/libsystemd-bus/sd-bus.c:1104:25: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'long unsigned int' [-Wformat=]
                         asprintf(&b->address, UNIX_USER_BUS_FMT, (unsigned long) getuid());
2014-01-05 11:17:03 -05:00
Kay Sievers
4bf7665c76 Revert "bus: driverd: don't attempt to remove from empty list"
We need to find the real reason for the failure, this just
avoids the symptoms.

This reverts commit 215c7625dd.
2014-01-05 18:55:03 +04:00
George McCollister
af13a6b060 journal: Add missing byte order conversions
Convert entry_array.items[0] to host byte order prior to passing it to
chain_cache_put().

[zj: also use le64toh in journal-verify.c]

https://bugs.freedesktop.org/show_bug.cgi?id=73194
2014-01-05 09:36:32 -05:00
Zbigniew Jędrzejewski-Szmek
7195aa42e3 shared/install: use char** convention for strvs 2014-01-05 09:16:15 -05:00
Zbigniew Jędrzejewski-Szmek
cc3d61683d Remove unused variables 2014-01-05 09:16:15 -05:00
Simon Peeters
e3e45d4f82 strv: multiple cleanups
- turn strv_merge into strv_extend_strv.
   appending strv b to the end of strv a instead of creating a new strv
- strv_append: remove in favor of strv_extend and strv_push.
- strv_remove: write slightly more elegant
- strv_remove_prefix: remove unused function
- strv_overlap: use strv_contains
- strv_printf: STRV_FOREACH handles NULL correctly
2014-01-05 09:16:15 -05:00
Simon Peeters
bf85c24daa shared: util.c: unify split and split_quoted 2014-01-05 09:16:15 -05:00
David Herrmann
e10e429f2d TODO: extend login capability note
We cannot remove CAP_SYS_ADMIN, which basically makes removing all other
capabilities useless. Anyhow, still wouldn't hurt checking whether stuff
like CAP_KILL can be dropped from logind.
2014-01-05 13:59:12 +01:00
Marcel Holtmann
479e339e55 hwdb: update 2014-01-05 00:44:34 -08:00
Marc-Antoine Perennou
215c7625dd bus: driverd: don't attempt to remove from empty list 2014-01-05 11:36:04 +04:00
Mantas Mikulėnas
3f78871b03 bus: open user, not system, bus in bus_open_user_systemd() 2014-01-05 11:32:51 +04:00
Simon Peeters
b4696bce07 util.c: use read_one_line_file where possible 2014-01-05 00:59:13 -05:00
Simon Peeters
b68fa010f7 shared: procfs_file_alloca: handle pid==0
when pid is set to 0 use /proc/self
2014-01-05 00:59:13 -05:00
Stefan Beller
9dddaedfcc Update .mailmap file
This commit updates email addresses of people, who are already in the
.mailmap file, so I'd assume they have sorted out their viewpoint on
privacy within the .mailmap file.

The entries for this commit have been produced using:
        # Finding out duplicates by comparing email addresses:
        git shortlog -sne |awk '{ print $NF }' |sort |uniq -d

        # Finding out duplicates by comparing names:
        git shortlog -sne |awk '{ NF--; $1=""; print }' |sort |uniq -d
2014-01-05 00:43:22 -05:00
Stefan Beller
7bb01eff62 swap: remove if/else with the same data path
This was introduced in e1770af812 (2012-02-03, swap: replace failure
boolean by result enum).

This just removes unneeded lines of code, no functional change.
2014-01-05 00:43:22 -05:00
Zbigniew Jędrzejewski-Szmek
4cf8496d0a man: document some more bus functions 2014-01-05 00:43:22 -05:00
Tom Gundersen
b3070dc025 networkd: refuse to use .network files with missing Address/Gateway key
These keys are mandatory in [Address]/[Route] sections. Otherwise, we
hit an assert:

ens3: setting addresses
Assertion 'address->family == 2 || address->family == 10' failed at /build/amd64-generic/tmp/portage/sys-apps/systemd-9999-r1/work/systemd-9999/src/network/networkd-address.c:137, function address_configure(). Aborting.

Reported-by: Alex Polvi <alex.polvi@coreos.com>

At the same time make sure Route's Destination and Gateway uses the same address family.
2014-01-05 00:32:31 +01:00
Thomas Hindoe Paaboel Andersen
3563b896da man: typo fix 2014-01-04 23:21:13 +01:00
Dave Reisner
49002eb5f6 sd-event: add missing symbol, sd_event_source_set_io_fd
This appears to have been omitted in 30caf8f3af when the
the function was added.
2014-01-04 09:34:09 -05:00
Tom Gundersen
e3d563346c udev: net_id - handle virtio buses
This was already supported in path_id, so should be uncontroversial.
2014-01-04 15:21:58 +01:00
Tom Gundersen
d69b12ac8a Revert "net-util: add support for Type=ethernet"
This reverts commit 4cd1214db6.

This may still be fixed in the kernel, revert this for now until
we see how it all shakes out.
2014-01-04 15:21:58 +01:00
Thomas Hindoe Paaboel Andersen
39602c3905 systemctl: improve readability on failed commands
Not long ago a failed command would print:
"Failed to start something.service: ..."
regardless of whether the command was to start/stop/restart/etc.

With e3e0314 this was improved to print the method used. E.g. for stopping:
"Failed to StopUnit something.service: ..."

This patch matches the method to a more human readable word. E.g:
"Failed to stop something.service: ..."
2014-01-04 12:49:40 +01:00
Zbigniew Jędrzejewski-Szmek
cd6d5e1c76 man: document a batch of bus functions 2014-01-04 00:15:01 -05:00
Tom Gundersen
efb8612f9e man: networkd - document DHCP option 2014-01-03 21:07:01 +01:00
Tom Gundersen
4cd1214db6 net-util: add support for Type=ethernet
When DEVTYPE is not set for a nic, it means it is a wired/ethernet
device.
2014-01-03 20:55:23 +01:00
Tom Gundersen
8b264404b6 networkd: link hash uses 64, not 32 bit keys 2014-01-03 18:27:26 +01:00
Tom Gundersen
aa3437a573 networkd: print the ifindex of added links
This debug information may be useful when comapring to dropped rtnetlink messages.
2014-01-03 18:20:11 +01:00
Tom Gundersen
2672953bde networkd: improve logging
This gives a bit better messages when a link is added twice.
2014-01-03 16:56:09 +01:00
Tom Gundersen
efbc88b8ed networkd: improve link state change logging 2014-01-03 16:20:10 +01:00
Tom Gundersen
d0d311d62f networkd: add some debug info about notifications we ignore 2014-01-03 16:02:12 +01:00
Kay Sievers
88c59cb3c1 bus: always create --user bus when kdbus is active
We set the variable in the unit file for --user, so this check is
always true.
2014-01-03 02:59:05 +01:00
Tom Gundersen
ff25413852 networkd: link - explicitly set the link to be up if the call to IFF_UP succeeds
No need to wait for the NEWLINK message to arrive.
2014-01-03 02:18:55 +01:00
Zbigniew Jędrzejewski-Szmek
477e73b531 networkd: fix memory leak in error path 2014-01-02 19:49:49 -05:00
Zbigniew Jędrzejewski-Szmek
7384fa923e networkd: do not deference null pointer in cleanup 2014-01-02 19:49:43 -05:00
Zbigniew Jędrzejewski-Szmek
d4c636603a core: fix gcc unused variable warning 2014-01-02 19:49:33 -05:00
Zbigniew Jędrzejewski-Szmek
0349c608c8 bus: fix memleak in sd_bus_creds_new_from_pid 2014-01-02 19:45:48 -05:00
Zbigniew Jędrzejewski-Szmek
5ce70e5bcd Introduce cleanup functions for cap_free
Unfortunately a different cleanup function is necessary per type,
because cap_t** and char** are incompatible with void**.
2014-01-02 19:45:48 -05:00
Zbigniew Jędrzejewski-Szmek
ac6b760cee build-sys: add --disable-dbus autoconf option 2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
a0846368c8 build-sys: make valgrind-tests target output nicer 2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
4ebe732c0c rtnl: fix memory corruptions after realloc
struct sd_rtnl_message would keep two additional pointers into the hdr
field. Every time hdr was realloced, those pointers should be adjusted,
but weren't. It seems less error-prone to keep offsets instead.
2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
6ee4f99042 bus: break reference cycle between bus and messages
Because messages in the read and write queues hold a reference on the
bus, and the bus holds a reference on each of them, we would never
free the bus if the read or write queues were not empty. Explicitly
substract the number of messages in those queue from the bus reference
count when deciding whether to free or not.

A simple test which creates and unrefs simple objects is added.
2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
ccd06097c7 Use format patterns for usec_t, pid_t, nsec_t, usec_t
It is nicer to predefine patterns using configure time check instead of
using casts everywhere.

Since we do not need to use any flags, include "%" in the format instead
of excluding it like PRI* macros.
2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
ab9001a1e3 Move bus path definitions to def.h 2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
da13d4d20f core/service: check if mainpid matches only if it is set
https://bugzilla.redhat.com/show_bug.cgi?id=1047304
2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
a9244623f7 core/manager: print info about interesting signals
Information about signals which are not routinely received by systemd
are printed at info level. This should make it easier to see what is
happening in the system.
2014-01-02 19:45:47 -05:00
Zbigniew Jędrzejewski-Szmek
41aef6fc74 core/service: tweak messages on operation timeouts 2014-01-02 19:45:47 -05:00
Tom Gundersen
a2db1d6b3f libsystemd-dhcp: don't assert on client_stop()
We need to be able to stop the dhcp client at any time, and the function appears to be written to handle this.
2014-01-03 01:42:26 +01:00
Tom Gundersen
b1b532f58c networkd: dhcp - avoid null pointer dereference 2014-01-03 01:42:26 +01:00
Tom Gundersen
1746cf2ad7 networkd: add more asserts and ignore all events when link has failed 2014-01-03 01:42:26 +01:00
Kay Sievers
b11d8d1993 rules: drivers - do not reset RUN list 2014-01-03 01:32:03 +01:00