Yu Watanabe
e68131526b
analyze: actually select longest activated-time of services
...
Discovered by LGTM.
2018-06-27 14:54:19 +09:00
Yu Watanabe
944072fedd
journal-gateway: use localStorage["cursor"] only when it has valid value
...
Discovered by LGTM.
2018-06-27 14:50:23 +09:00
Yu Watanabe
c497e449f4
journal-gateway: explicitly declare local variables
...
Suggested by LGTM.
2018-06-27 14:22:28 +09:00
Yu Watanabe
affaed1e55
sd-bus: fix implicit downcast of bitfield reported by LGTM
2018-06-27 13:28:28 +09:00
Filipe Brandenburger
ad4bc33522
sleep: fix printf format of fiemap fields
...
Use PRIu64 and PRIu32 constants to also get the format right on LP-64
architectures.
For the 64-bit fields, we need a cast to (uint64_t), since __u64 is
defined as a `long long unsigned` and PRIu64 expects a `long unsigned`.
In practice, both are the same, so the cast should be OK.
2018-06-26 20:39:07 +02:00
Evegeny Vereshchagin
a7e9daf40c
README.md: add an LGTM badge
...
Now that @yuwata has fixed a lot of alerts, the badge looks
much better than before, so let's show it :-)
2018-06-26 18:15:09 +02:00
Neal Gompa
a6bb550458
rpm: Add misspelled %_environmentdir macro for temporary compatibility
...
This should be removed after systemd 240 is released.
Signed-off-by: Neal Gompa <ngompa13@gmail.com>
2018-06-26 07:43:41 -04:00
Yu Watanabe
e0f691e1fd
tree-wide: use localtime_r() instead of localtime()
...
Follow-up for e46acb7950a9f07ac60d772309de842c444ad2bd.
2018-06-26 14:26:39 +09:00
Yu Watanabe
ad16158c10
netdev: do not assign unused values
2018-06-26 14:26:19 +09:00
Jan Janssen
aa2cc005d7
crypt-util: Translate libcryptsetup log level instead of using log_debug()
...
This makes sure that errors reported by libcryptsetup are shown to the
user instead of getting swallowed up by log_debug().
2018-06-26 14:26:07 +09:00
Evegeny Vereshchagin
f3a020d153
coverity.sh: fail if uploading data to Coverity Scan is forbidden
2018-06-25 22:22:29 +00:00
Evegeny Vereshchagin
1e79d09ef9
coverity.sh: use a comma to separate module names
...
Otherwise Python bails out with
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
NameError: name 'json' is not defined
```
See https://travis-ci.org/systemd/systemd/jobs/397490437
2018-06-25 22:02:41 +00:00
Evegeny Vereshchagin
096eec29cd
coverity.sh: make the script compatible with Python 3
2018-06-25 21:59:28 +00:00
Evegeny Vereshchagin
eeeaebf9c5
coverity.sh: fix a couple indents
2018-06-25 21:57:43 +00:00
Yu Watanabe
b34a21083b
man: add missing option for system.conf
2018-06-26 04:07:44 +09:00
Yu Watanabe
e761599ffd
core: add missing option and drop nonexistent option in system.conf
2018-06-26 04:07:19 +09:00
Yu Watanabe
2dcacc7363
journal: add missing option in journald.conf
2018-06-26 04:05:42 +09:00
Yu Watanabe
a4d5708c79
journal-remote: add license and reference to man page in conf files
2018-06-26 04:04:45 +09:00
Yu Watanabe
3632149409
network: provide default networkd.conf
2018-06-26 03:34:49 +09:00
Lennart Poettering
e46acb7950
timedate: use gmtime_r() and localtime_r()
...
gmtime() and localtime() operate on a static buffer. let's avoid this,
as we never know whether some library might use these calls in some
backrgound thread.
Discovered by lgtm:
https://lgtm.com/projects/g/systemd/systemd/
2018-06-25 19:20:34 +02:00
Zbigniew Jędrzejewski-Szmek
e49807606d
Merge pull request #9411 from poettering/systemctl-is-running-fixes
...
tiny systemctl fixes
2018-06-25 19:03:31 +02:00
Neal Gompa
6ea4cb975f
rpm: Fix typo in %_environmentdir
...
Signed-off-by: Neal Gompa <ngompa13@gmail.com>
2018-06-25 12:56:50 -04:00
Yu Watanabe
48847676ca
man: add comments about MTUBytes= and MACAddress= for tuntap devices
...
Closes #9407 .
2018-06-25 18:54:38 +02:00
Zbigniew Jędrzejewski-Szmek
dfe23d4145
Merge pull request #4522 from lucaswerkmeister/unescape-template
...
escape: support --unescape with --template
2018-06-25 18:48:01 +02:00
Lennart Poettering
5e4c5bde5c
busctl: make parameter const
...
it's initialized from an argv[] entry, hence let's be make it
non-writable by default.
2018-06-25 18:26:17 +02:00
Yu Watanabe
f02582f69f
meson: check whether gnutls supports TCP fast open
...
Fixes #9403
2018-06-26 00:30:29 +09:00
Lennart Poettering
bfeec178db
systemctl: if we can't detect the system-is-running state, assume it's not running
2018-06-25 17:10:27 +02:00
Lennart Poettering
e686a616e8
systemctl: log errors to LOG_DEBUG rather than eating them up entirely
2018-06-25 17:10:27 +02:00
Lennart Poettering
9897b09ba7
systemctl: add 'static' to constant state array
2018-06-25 17:10:27 +02:00
Zbigniew Jędrzejewski-Szmek
7f1fc7c6d4
bls: allow firmware-supported file systems
...
This copies the text from Matthew Garrett's version verbatim. At
least MacOS uses HFS+ for their ESP.
2018-06-25 15:39:54 +02:00
Ludwin Janvier
99d4345b30
[hwdb] Add support for HP ProBook 650 wifi switch key ( #9260 )
...
Add support for HP ProBook 650 wifi switch key
2018-06-25 13:18:13 +02:00
Filipe Brandenburger
b02a7e1aea
resolved: assert t->server is set in dns_transaction_emit_tcp.
...
Uncovered by Coverity. Fixes CID 1393390.
2018-06-25 13:17:25 +02:00
Filipe Brandenburger
53a2383b8b
core/job: add check for return of job_type_merge_and_collapse()
...
Using an assertion is fine, since calls to job_merge_into_installed()
are protected by a check for job_type_is_conflicting().
Uncovered by Coverity, fixes CID 996307.
2018-06-25 13:16:38 +02:00
M0Rf30
a2680b6f27
hwdb: added accelerometer quirk for Aspire Switch 10 (sw5-011)
2018-06-25 13:13:10 +02:00
Lennart Poettering
2919425bab
Merge pull request #9398 from yuwata/lgtm-fixes
...
fixes error handlings and several cleanups suggested by LGTM
2018-06-25 13:12:44 +02:00
Michal Koutný
1e75824cb0
core/manager: Make sure jobs statistics are not double after daemon-reload
...
We add n_installed_jobs and n_failed_jobs to our inner state after
deserialization. This is fine during daemon-reexec when we start with clear
Manager (and some jobs possibly queued before deserialization), however,
daemon-reload works with the same manager and adding the values would
effectively double the counters. Reset the counters before we deserialize and
add their values again.
2018-06-25 11:18:44 +02:00
Michal Koutný
1a0d353b44
man: SystemMaxUse= clarification in journald.conf(5)
...
Similar semantics applies to {System,Runtime}MaxUse= as to
{System,Runtime}MaxFiles=, i.e. active files aren't vacuumed and the limit
is not thus strictly honored.
2018-06-25 11:18:20 +02:00
Lucas Werkmeister
d936cddcb5
escape: add --instance option
...
Suggested by @keszybz in #4522 .
2018-06-25 11:17:55 +02:00
Zbigniew Jędrzejewski-Szmek
d3a27ed402
boot: do not assume the last character in cmdline is a newline
...
Fixes #9401 .
2018-06-25 11:17:53 +02:00
Lucas Werkmeister
e563e2534c
escape: support --unescape with --template
2018-06-25 11:13:38 +02:00
Yu Watanabe
400d846138
tmpfiles: specify access mode for /run/systemd/netif
...
This partially reverts 2af767729489f6baa98a2641b2007acab44ed353.
As the directories are certainly readable and not-writable by
non-privileged users.
2018-06-25 10:32:13 +02:00
Yu Watanabe
fb14aa7ecc
network: fix log message
2018-06-25 10:31:08 +02:00
Yu Watanabe
a9061d97a7
timesync: update log message
...
Fixes #9388 .
2018-06-25 10:27:18 +02:00
Yu Watanabe
75ca1621db
timesync: changes type of drift_freq to int64_t
...
drift_freq is used for storing timex.freq, and is a 64bit integer.
To support x32 ABI, this changes the type of drift_freq to int64_t.
Fixes #9387 .
2018-06-25 10:27:18 +02:00
Sandy
e05c8b4462
hwdb: Fix secondary backslash on MSI GS65 laptop
...
The MSI GS65 Stealth Thin series laptop contains an extra physical backslash key next to the spacebar which does not yield the correct keycode.
This pull request fixes the issue
2018-06-25 09:53:43 +02:00
RussianNeuroMancer
c9dce41d1b
Add resolution of Trust Flex Graphics Tablet to hwdb
...
Product:
https://www.trust.com/en/product/21259-flex-design-tablet-black
http://trust.com/21259
Support in libinput is already in place since libinput 1.11 release (I tested it)
https://gitlab.freedesktop.org/libinput/libinput/issues/38
So only missing part is definition in hwdb.
2018-06-25 14:18:11 +09:00
Evegeny Vereshchagin
8cc9d18881
docs: put LGTM on the list of QA tools and fix a couple typos
2018-06-25 14:13:53 +09:00
Yu Watanabe
d5c3091122
install: fix error handling in is_symlink_with_known_name()
2018-06-25 14:07:16 +09:00
Yu Watanabe
99c89da02d
portable: fix error handling
2018-06-25 13:56:27 +09:00
Yu Watanabe
d61b34f1b2
import: drop unnecessary condition
2018-06-25 13:54:44 +09:00