Yu Watanabe
47a277f18b
network: use log_link_xxx() at more places
2020-10-07 02:39:51 +09:00
Yu Watanabe
8c11221879
network: drop NextHop::oif and always use link ifindex
2020-10-07 02:39:51 +09:00
Yu Watanabe
cf5a228f7b
network: slightly shorten nexthop_compare_func()
2020-10-07 02:39:51 +09:00
Yu Watanabe
75156ccbdc
network: cleanup headers included in networkd-nexthop.h
2020-10-07 02:39:51 +09:00
Yu Watanabe
b82663ddee
network: drop list of static nexthops
...
[NextHop] sections are managed by both LIST and Hashmap.
Let's drop list, as they store the completely same information.
2020-10-07 02:39:51 +09:00
Yu Watanabe
8d7b137a82
network: drop unused nexthop_remove() and nexthop_equal()
2020-10-07 02:39:51 +09:00
Yu Watanabe
4736035aaa
network: make several functions static
2020-10-07 02:39:51 +09:00
Yu Watanabe
454c87b5d5
network: move manager_rtnl_process_nexthop() to networkd-nexthop.c
2020-10-07 02:39:51 +09:00
Yu Watanabe
c133770a6b
network: move link_request_set_nexthop() to networkd-nexthop.c
2020-10-07 02:39:51 +09:00
Yu Watanabe
446aaaf35f
network: introduce helper function to enumerate information using netlink
2020-10-07 02:39:13 +09:00
Yu Watanabe
d08ed5a1fd
network: specify all known attributes when removing routing policy rules
...
Otherwise, routing_policy_rule_remove() may removes unintended rule.
2020-10-07 02:36:29 +09:00
Yu Watanabe
5a82104bf3
network: add missing "else"
2020-10-07 02:36:29 +09:00
Yu Watanabe
6f3337277f
network: drop unused element
2020-10-07 02:36:29 +09:00
Yu Watanabe
50a3682f1e
network: introduce network_verify_routing_policy_rules()
2020-10-07 02:36:29 +09:00
Yu Watanabe
f1828a222a
network: make routing_policy_rule_new() static
2020-10-07 02:36:29 +09:00
Yu Watanabe
51a0dc4a15
network: move manager_rtnl_process_rule() to networkd-routing-policy-rule.[ch]
2020-10-07 02:36:29 +09:00
Yu Watanabe
8dfed23d92
network: use typesafe macro netlink_add_match()
2020-10-07 02:36:29 +09:00
Yu Watanabe
3d65f7c863
sd-netlink: fix typo and make netlink_add_match() take description
2020-10-07 02:36:29 +09:00
Yu Watanabe
0d7d377b80
network: move log_message_warning_errno() to networkd-util.h
2020-10-07 02:36:29 +09:00
Yu Watanabe
ca183bf8fd
network: drop list of static routing policy rules
...
[RoutingPolicyRule] sections are managed by both LIST and Hashmap.
Let's drop list.
2020-10-07 02:36:29 +09:00
Yu Watanabe
02e9f4e536
network: do not duplicate rule if Family=both
2020-10-07 02:36:29 +09:00
Yu Watanabe
b0815fa499
network: make routing_policy_rule_free() returns NULL
2020-10-07 02:36:29 +09:00
Yu Watanabe
816ef8d1da
network: add more logs on loading routing policy rules failure
...
And reduce scope of variables.
2020-10-07 02:36:24 +09:00
Yu Watanabe
eb3445ce93
network: reduce scope of variables
2020-10-06 00:51:01 +09:00
Yu Watanabe
ddc9df3183
network: drop routing_policy_rule_make_local()
...
Its error handling was bogus...
2020-10-06 00:51:01 +09:00
Yu Watanabe
7532b88808
network: make several functions static
2020-10-06 00:51:01 +09:00
Yu Watanabe
c0ec474675
network: move link_request_set_routing_policy()
2020-10-06 00:51:01 +09:00
Lennart Poettering
ddd6dd9f23
man: fix table alignment
2020-10-05 17:46:15 +02:00
Zbigniew Jędrzejewski-Szmek
b182195acc
NEWS: shorten/reword some things
2020-10-05 13:29:37 +02:00
Lennart Poettering
5a8d00e8ca
virt: reference correct file path in log message
2020-10-05 11:40:48 +02:00
Lennart Poettering
6f5cf88009
man: fix typo systmed → systemd
2020-10-05 11:40:48 +02:00
Lennart Poettering
8cf7b161eb
update TODO
2020-10-05 11:40:48 +02:00
Lennart Poettering
db2db708d8
add stuff to NEWS for 247
2020-10-05 11:40:48 +02:00
Lucas Werkmeister
7c57a030e0
shell-completion: add missing completions to meson.build
...
Completions for systemd-id128 and homectl have been available for a
while, but weren’t being installed.
2020-10-05 08:05:41 +02:00
Zbigniew Jędrzejewski-Szmek
12bab3579f
Merge pull request #17230 from mrc0mmand/coccinelle_fixes
...
coccinelle: fix the incorrect transformation/isomorphisms
2020-10-05 08:03:40 +02:00
Daan De Meyer
8e4a44c585
Merge pull request #17239 from ferivoz/typos
...
Fix typos
2020-10-04 18:19:26 +01:00
Frantisek Sumsal
1d6cc5d0e5
tree-wide: coccinelle fixes
2020-10-04 12:32:21 +02:00
Frantisek Sumsal
135a9868a7
coccinelle: skip strjoin transformation in test_strjoin()
2020-10-04 12:32:21 +02:00
Frantisek Sumsal
1813613fed
coccinelle: limit the # of expressions in in_set/not_in_set
...
transformations. Otherwise the time and resources to generate all
possible permutations is simply unreasonable for running on local
machines.
2020-10-04 12:32:21 +02:00
Frantisek Sumsal
cb60571b31
coccinelle: skip the xsprintf transformation on man pages
...
since we don't expose xsprintf to users.
2020-10-04 12:32:21 +02:00
Frantisek Sumsal
aad54dbc74
coccinelle: disable flags-set where it doesn't make sense
2020-10-04 12:32:21 +02:00
Frantisek Sumsal
473de9b708
coccinelle: fix the equals-null transformation
...
The original issue with this transformation was that we were replacing
the whole if statement instead of just the expression inside. That
caused the code to be weirdly formatted, as Coccinelle put a new block
around each replaced if statement.
This version replaces just the inner expression if it's in its incorrect
form, otherwise it just accepts it (to avoid recursion).
2020-10-04 12:32:21 +02:00
Frantisek Sumsal
3bc3c734c6
coccinelle: drop the custom isomorphisms
...
My former dumb me didn't read the documentation properly, so with the
introduction of custom isomorphisms I caused two issues:
1) Masked all standard isomorphisms defined by Coccinelle
2) Replace the original issue with a completely new one
2020-10-04 12:32:21 +02:00
Daan De Meyer
d62e09c1eb
Merge pull request #17233 from poettering/nspawn-reopen-fix
...
nspawn: reopen stdin/stdout + chmod fixes for stdin/stdout
2020-10-03 13:26:54 +01:00
Samanta Navarro
5e2b0e1cfa
man: fix typos
2020-10-03 11:56:50 +00:00
Samanta Navarro
7b121df640
seccomp-util: fix typo in help message
2020-10-03 11:56:40 +00:00
Lennart Poettering
278c13431b
github: ask for arch+kernel in bug report form
...
Quite often we see kernel and arch specific issues, let's ask for the
version right-away when people file the issue.
Other tweaks.
2020-10-02 12:38:28 +02:00
Lennart Poettering
3462d773d2
nspawn: don't chown() stdin/stdout passed in when --console=pipe is used
...
We should chown what we allocate ourselves, i.e. any pty we allocate
ourselves. But for stuff we propagate, let's avoid that: we shouldn't
make more changes than necessary.
Fixes : #17229
2020-10-02 12:05:08 +02:00
Lennart Poettering
781fa474d8
ptyfwd: reopen stdin/sdout before setting O_NONBLOCK
...
If we set O_NONBLOCK on stdin/stdout directly this means the flag is
left set when we abort abnormally, as we don't get the chance to reset
it again on exit. This might confuse progrms invoking us. Moreover, if
programs invoking us continue to write to the stdout passed to us, they
might be confused by non-blocking mode too.
Hence, let's avoid this if possible: let's reopen stdin/stdout and set
O_NONBLOCK only on the reopend fds, leaving the original fds as they
are.
Prompted-by: https://github.com/systemd/systemd/pull/17070#issuecomment-702304802
2020-10-02 12:04:20 +02:00
Lennart Poettering
c14ebe07a9
Merge pull request #17172 from keszybz/read-login-defs
...
Read /etc/login.defs
2020-10-02 11:01:30 +02:00