1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-14 15:21:37 +03:00
Commit Graph

53 Commits

Author SHA1 Message Date
Lennart Poettering
f01e5736f1 timesyncd: move the generic sockaddr_equal() call to socket-util.h 2014-08-12 14:54:32 +02:00
Lennart Poettering
cedc8c44d4 timesyncd: when we don't know anything about the network state, assume we are online
This should provide better compatibility with systems that lack networkd
2014-08-11 22:04:37 +02:00
Lennart Poettering
6a5c7b7e41 timesyncd: always use CLOCK_BOOTTIME if we can
After all we want to compare a monotonically increasing clock with the
remote clock, hence we shouldn't ignore system suspend periods.
2014-08-11 15:06:22 +02:00
Zbigniew Jędrzejewski-Szmek
b2fadec604 Properly report invalid quoted strings
$ systemd-analyze verify trailing-g.service
[./trailing-g.service:2] Trailing garbage, ignoring.
trailing-g.service lacks ExecStart setting. Refusing.
Error: org.freedesktop.systemd1.LoadFailed: Unit trailing-g.service failed to load: Invalid argument.
Failed to create trailing-g.service/start: Invalid argument
2014-07-31 08:56:03 -04:00
Zbigniew Jędrzejewski-Szmek
a2a5291b3f Reject invalid quoted strings
String which ended in an unfinished quote were accepted, potentially
with bad memory accesses.

Reject anything which ends in a unfished quote, or contains
non-whitespace characters right after the closing quote.

_FOREACH_WORD now returns the invalid character in *state. But this return
value is not checked anywhere yet.

Also, make 'word' and 'state' variables const pointers, and rename 'w'
to 'word' in various places. Things are easier to read if the same name
is used consistently.

mbiebl_> am I correct that something like this doesn't work
mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-passwd "Unlock EncFS"'
mbiebl_> systemd seems to strip of the quotes
mbiebl_> systemctl status shows
mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-password Unlock EncFS  $RootDir $MountPoint
mbiebl_> which is pretty weird
2014-07-31 04:00:31 -04:00
Kay Sievers
c264aeab4b core: only set the kernel's timezone when the RTC runs in local time
We can not reliably manage any notion of local time. Every daylight
saving time change or time zone change by traveling will make the
time jump, and the local time might jump backwards which creates
unsolvable problems with file timestamps.

We will no longer tell the kernel our local time zone and leave
everything set to UTC. This will effectively turn FAT timestamps
into UTC timestamps.

If and only if the machine is configured to read the RTC in local
time mode, the kernel's time zone will be configured, but
systemd-timesysnc will disable the kernel's system time to RTC
syncing. In this mode, the RTC will not be managed, and external
tools like Windows bootups are expected to manage the RTC's time.

https://bugs.freedesktop.org/show_bug.cgi?id=81538
2014-07-27 10:44:31 +02:00
Lennart Poettering
0014a4ad50 sd-network: fix parameter order for sd_network_monitor_new()
Constructors should return the object they created as first parameter,
except when they are generated as a child/member object of some other
object in which case that should be first.
2014-07-17 01:41:52 +02:00
Zbigniew Jędrzejewski-Szmek
36f822c4bd Let config_parse open file where applicable
Special care is needed so that we get an error message if the
file failed to parse, but not when it is missing. To avoid duplicating
the same error check in every caller, add an additional 'warn' boolean
to tell config_parse whether a message should be issued.
This makes things both shorter and more robust wrt. to error reporting.
2014-07-16 18:47:20 -04:00
Zbigniew Jędrzejewski-Szmek
e9f3d2d508 Constify ConfigTableItem tables 2014-07-15 22:34:40 -04:00
Zbigniew Jędrzejewski-Szmek
ae2db4e7e8 timesyncd: add sockaddr_pretty wrapper 2014-07-15 09:53:18 -04:00
Zbigniew Jędrzejewski-Szmek
c566ee3253 timesyncd: only listen to clock changes when connected
This reverts previous commit and applies a different fix.

manager_clock_watch() callback calls manager_send_request() to kick
off a resync. We can only do that when we're actually connected to
something. It is not useful to setup the callback from manager_new().

Now the callback will be dropped in manager_connect() and requested
in manager_begin().

https://bugs.freedesktop.org/show_bug.cgi?id=80932
2014-07-15 09:52:19 -04:00
Kay Sievers
afc7b1b9c1 timesyncd: suppress resync at system time change when not connected
Jul 04 17:46:03 orchid systemd[1]: Starting Network Time Synchronization...
Jul 04 17:46:03 orchid systemd[1]: Started Network Time Synchronization.
Jul 04 17:46:22 orchid systemd-timesyncd[301]: System time changed. Resyncing.
Jul 04 17:46:22 orchid systemd-timesyncd[301]: Assertion 'm->current_server_name'

https://bugs.freedesktop.org/show_bug.cgi?id=80932
2014-07-15 02:24:35 +02:00
Lennart Poettering
c92e531c82 resolved: make use of union in_addr_union in resolved, too 2014-07-07 23:11:48 +02:00
Lennart Poettering
966bff2660 timesyncd: split privilege dropping code out of timesyncd so that we can make use of it from other daemons too
This is preparation to make networkd work as unpriviliged user.
2014-06-01 08:49:33 +02:00
Kay Sievers
4d40d39cdf timesysnc: reword network watching messages, and move resolver errors to debug 2014-05-25 13:46:43 +08:00
Kay Sievers
d636d37679 timesyncd: only update stamp file when we are synchronized
Create initial stamp file with compiled-in time to prevent bootups
with clocks in the future from storing invalid timestamps.

At shutdown, only update the timestamp if we got an authoritative
time to store.
2014-05-24 08:04:56 +08:00
Lennart Poettering
609e002e78 time-util: make sure USEC_PER_SEC and friends are actually of type usec_t 2014-05-22 11:44:03 +09:00
Kay Sievers
a6cb8f870d timesyncd: use STR_IN_SET() 2014-05-21 10:36:02 +09:00
Lennart Poettering
a57a27b2ef timesyncd: fix english language typo 2014-05-21 09:36:49 +09:00
Lennart Poettering
ece6e766cf timesyncd: save clock to disk everytime we get an NTP fix, and bump clock at boot using this
This is useful to make sure the system clock stays monotonic even on
systems that lack an RTC.

Also, why we are at it, also use the systemd release time for bumping
the clock, since it's a slightly less bad than starting with jan 1st,
1970.

This also moves timesyncd into the early bootphase, in order to make
sure this initial bump is guaranteed to have finished by the time we
start real daemons which might write to the file systemd and thus
shouldn't leave 1970's timestamps all over the place...
2014-05-21 00:23:39 +09:00
Tom Gundersen
e56f363803 timesyncd: only attempt to connect when an address is configured
For now, we accept both link-local and routable addresses, maybe we want to
restrict ourselves to routable addresses only.
2014-05-19 20:54:42 +02:00
Nis Martensen
f1721625e7 fix spelling of privilege 2014-05-19 00:40:44 +09:00
Lennart Poettering
f864fd1b4b timesyncd: make use of floating event sources for signal handling 2014-05-18 20:52:49 +09:00
Lennart Poettering
9f7115498b timesyncd: enable watchdog support 2014-05-18 20:52:49 +09:00
Lennart Poettering
a349eb10d3 timesyncd: run timesyncd as unpriviliged user "systemd-timesync" (but still with CAP_SYS_TIME) 2014-05-18 20:52:49 +09:00
Kay Sievers
15a224e06c timesyncd: fix typo in comment 2014-05-16 04:00:59 +02:00
Kay Sievers
59a9fce47b timesyncd: fix error path return value
https://bugs.freedesktop.org/show_bug.cgi?id=78752
2014-05-15 20:50:02 +02:00
Tom Gundersen
9b3310b066 timesyncd: read global operational state from networkd 2014-05-08 17:32:32 +02:00
Tom Gundersen
e0e5ce237b timesyncd: only run when the system has a carrier on a network interface
As the operational state detection in sd-network is still too primitive, timesyncd
will likely try to connect a bit early, so the first attempt will fail.
2014-05-08 15:28:19 +02:00
Kay Sievers
089377209f timesyncd: shorten log message 2014-05-07 14:45:32 +02:00
Lennart Poettering
7b8b9686e0 timesyncd: hook up systemd-timesyncd with systemd-timedated
Later on we will probably remove support for controlling any other NTP
implementations but systemd-timesyncd, but for now, let's keep things
generic
2014-05-06 18:20:49 +02:00
Lennart Poettering
661278ee29 timesyncd: never accept NTP time from server that is older than systemd's release time 2014-05-06 18:08:04 +02:00
Lennart Poettering
e8af69739a timesyncd: read server settings from a configuration file
Also, allow compiling in a default server list via a configure command
line item.
2014-05-06 17:02:11 +02:00
Lennart Poettering
16c058ba01 timesyncd: when an NTP server doesn't respond, proceed with the next 2014-05-06 16:15:02 +02:00
Lennart Poettering
376cd3b89c list: make LIST_FIND_TAIL work for empty lists 2014-05-06 13:07:15 +02:00
Lennart Poettering
600809211e timesyncd: keep order of NTP servers 2014-05-06 12:34:37 +02:00
Lennart Poettering
05f7fc0fe3 timesyncd: make sure to reread /etc/resolv.conf when we try the next NTP server 2014-05-06 12:34:37 +02:00
Kay Sievers
136aa3b444 timesyncd: accept NTP version 3 responses 2014-05-06 12:29:20 +02:00
Lennart Poettering
881c74201d timesyncd: add a more servers by default 2014-05-06 01:37:29 +02:00
Lennart Poettering
becad8f1ed timesyncd: also try next server when sendto() fails 2014-05-06 01:37:13 +02:00
Lennart Poettering
7a183c4c73 timesyncd: don't busy loop when we cannot connect to any servers 2014-05-06 01:29:47 +02:00
Lennart Poettering
678522cff0 timesyncd: properly handle multiple configured NTP servers and multiplei IP addresses per server name 2014-05-06 01:17:35 +02:00
Lennart Poettering
856a5a7d76 timesyncd: lookup name server via sd-resolve, support IPv6, react to SIGINT/SITERM 2014-05-05 23:53:17 +02:00
Lennart Poettering
7ed0dd4be6 timesync: use safe_close() where possible 2014-05-05 21:47:38 +02:00
Lennart Poettering
5f8cfaee52 timesync: always initialize structs when declaring them as far as possible with contsant values 2014-05-05 21:47:09 +02:00
Kay Sievers
ee03381e21 timesyncd: log drift value as signed 2014-05-05 14:21:40 +02:00
Kay Sievers
ef6191945e timesyncd: log drift correction 2014-05-03 15:09:33 +02:00
Kay Sievers
d67006fe53 timesyncd: use nanosecond mode 2014-04-30 17:25:46 +02:00
Kay Sievers
81c36b3f28 timesyncd: remove debug code 2014-04-30 09:37:59 +02:00
Kay Sievers
ba9f11dc98 timesyncd: limit debug values to milliseconds 2014-04-29 23:48:23 +02:00