mirror of
https://github.com/systemd/systemd.git
synced 2024-11-05 23:51:28 +03:00
bb38678e3c
There's still a slight race condition when using udevadm settle, if the udev daemon has a pending inotify event but hasn't yet generated the "change" uevent for it, the kernel and udev sequence numbers will match and settle will exit. Now udevadm settle will send a control message to udevd, which will respond by sending SIGUSR1 back to the waiting udevadm settle once it has completed the main loop iteration in which it received the control message. If there were no pending inotify events, this will simply wake up the udev daemon and allow settle to continue. If there are pending inotify events, they are handled first in the main loop so when settle is continued they will have been turned into uevents and the kernel sequence number will have been incremented. Since the inotify event is pending for udevd when the close() system call returns (it's queued as part of the kernel handling for that system call), and since the kernel sequence number is incremented by writing to the uevent file (as udevd does), this solves the race. When the settle continues, if there were pending inotify events that udevd had not read, they are now pending uevents which settle can wait for. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
214 lines
5.4 KiB
C
214 lines
5.4 KiB
C
/*
|
|
* Copyright (C) 2006-2008 Kay Sievers <kay@vrfy.org>
|
|
* Copyright (C) 2009 Canonical Ltd.
|
|
* Copyright (C) 2009 Scott James Remnant <scott@netsplit.com>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include <stddef.h>
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
#include <errno.h>
|
|
#include <dirent.h>
|
|
#include <fcntl.h>
|
|
#include <syslog.h>
|
|
#include <getopt.h>
|
|
#include <signal.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
|
|
#include "udev.h"
|
|
|
|
#define DEFAULT_TIMEOUT 180
|
|
#define LOOP_PER_SECOND 20
|
|
|
|
static int volatile is_timeout;
|
|
|
|
static void asmlinkage sig_handler(int signum)
|
|
{
|
|
switch (signum) {
|
|
case SIGALRM:
|
|
is_timeout = 1;
|
|
case SIGUSR1:
|
|
;
|
|
}
|
|
}
|
|
|
|
int udevadm_settle(struct udev *udev, int argc, char *argv[])
|
|
{
|
|
static const struct option options[] = {
|
|
{ "seq-start", required_argument, NULL, 's' },
|
|
{ "seq-end", required_argument, NULL, 'e' },
|
|
{ "timeout", required_argument, NULL, 't' },
|
|
{ "quiet", no_argument, NULL, 'q' },
|
|
{ "help", no_argument, NULL, 'h' },
|
|
{}
|
|
};
|
|
unsigned long long start = 0;
|
|
unsigned long long end = 0;
|
|
int quiet = 0;
|
|
int timeout = 0;
|
|
struct sigaction act;
|
|
struct udev_queue *udev_queue = NULL;
|
|
int rc = 0;
|
|
|
|
dbg(udev, "version %s\n", VERSION);
|
|
|
|
/* set signal handlers */
|
|
memset(&act, 0x00, sizeof(act));
|
|
act.sa_handler = (void (*)(int)) sig_handler;
|
|
sigemptyset (&act.sa_mask);
|
|
act.sa_flags = 0;
|
|
sigaction(SIGALRM, &act, NULL);
|
|
sigaction(SIGUSR1, &act, NULL);
|
|
|
|
while (1) {
|
|
int option;
|
|
int seconds;
|
|
|
|
option = getopt_long(argc, argv, "s:e:t:qh", options, NULL);
|
|
if (option == -1)
|
|
break;
|
|
|
|
switch (option) {
|
|
case 's':
|
|
start = strtoull(optarg, NULL, 0);
|
|
break;
|
|
case 'e':
|
|
end = strtoull(optarg, NULL, 0);
|
|
break;
|
|
case 't':
|
|
seconds = atoi(optarg);
|
|
if (seconds >= 0)
|
|
timeout = seconds;
|
|
else
|
|
fprintf(stderr, "invalid timeout value\n");
|
|
dbg(udev, "timeout=%i\n", timeout);
|
|
break;
|
|
case 'q':
|
|
quiet = 1;
|
|
break;
|
|
case 'h':
|
|
printf("Usage: udevadm settle OPTIONS\n"
|
|
" --timeout=<seconds> maximum time to wait for events\n"
|
|
" --seq-start=<seqnum> first seqnum to wait for\n"
|
|
" --seq-end=<seqnum> last seqnum to wait for\n"
|
|
" --quiet do not print list after timeout\n"
|
|
" --help\n\n");
|
|
goto exit;
|
|
}
|
|
}
|
|
|
|
if (timeout > 0)
|
|
alarm(timeout);
|
|
else
|
|
alarm(DEFAULT_TIMEOUT);
|
|
|
|
udev_queue = udev_queue_new(udev);
|
|
if (udev_queue == NULL)
|
|
goto exit;
|
|
|
|
if (start > 0) {
|
|
unsigned long long kernel_seq;
|
|
|
|
kernel_seq = udev_queue_get_kernel_seqnum(udev_queue);
|
|
|
|
/* unless specified, the last event is the current kernel seqnum */
|
|
if (end == 0)
|
|
end = udev_queue_get_kernel_seqnum(udev_queue);
|
|
|
|
if (start > end) {
|
|
err(udev, "seq-start larger than seq-end, ignoring\n");
|
|
fprintf(stderr, "seq-start larger than seq-end, ignoring\n");
|
|
start = 0;
|
|
end = 0;
|
|
}
|
|
|
|
if (start > kernel_seq || end > kernel_seq) {
|
|
err(udev, "seq-start or seq-end larger than current kernel value, ignoring\n");
|
|
fprintf(stderr, "seq-start or seq-end larger than current kernel value, ignoring\n");
|
|
start = 0;
|
|
end = 0;
|
|
}
|
|
info(udev, "start=%llu end=%llu current=%llu\n", start, end, kernel_seq);
|
|
} else {
|
|
if (end > 0) {
|
|
err(udev, "seq-end needs seq-start parameter, ignoring\n");
|
|
fprintf(stderr, "seq-end needs seq-start parameter, ignoring\n");
|
|
end = 0;
|
|
}
|
|
}
|
|
|
|
/* guarantee that the udev daemon isn't pre-processing */
|
|
if (getuid() == 0) {
|
|
struct udev_ctrl *uctrl;
|
|
|
|
uctrl = udev_ctrl_new_from_socket(udev, UDEV_CTRL_SOCK_PATH);
|
|
if (uctrl != NULL) {
|
|
sigset_t mask, oldmask;
|
|
|
|
sigemptyset(&mask);
|
|
sigaddset(&mask, SIGUSR1);
|
|
sigaddset(&mask, SIGALRM);
|
|
sigprocmask(SIG_BLOCK, &mask, &oldmask);
|
|
if (udev_ctrl_send_settle(uctrl) > 0)
|
|
sigsuspend(&oldmask);
|
|
udev_ctrl_unref(uctrl);
|
|
}
|
|
}
|
|
|
|
while (!is_timeout) {
|
|
/* exit if queue is empty */
|
|
if (udev_queue_get_queue_is_empty(udev_queue))
|
|
break;
|
|
|
|
/* if asked for, wait for a specific sequence of events */
|
|
if (start > 0) {
|
|
unsigned long long seq;
|
|
int finished;
|
|
|
|
finished = 0;
|
|
for (seq = start; seq <= end; seq++) {
|
|
finished = udev_queue_get_seqnum_is_finished(udev_queue, seq);
|
|
if (!finished)
|
|
break;
|
|
}
|
|
if (finished)
|
|
break;
|
|
}
|
|
usleep(1000 * 1000 / LOOP_PER_SECOND);
|
|
}
|
|
|
|
/* if we reached the timeout, print the list of remaining events */
|
|
if (is_timeout) {
|
|
struct udev_list_entry *list_entry;
|
|
|
|
if (!quiet) {
|
|
info(udev, "timeout waiting for udev queue\n");
|
|
printf("\nudevadm settle - timeout of %i seconds reached, the event queue contains:\n", timeout);
|
|
udev_list_entry_foreach(list_entry, udev_queue_get_queued_list_entry(udev_queue))
|
|
printf(" %s (%s)\n",
|
|
udev_list_entry_get_name(list_entry),
|
|
udev_list_entry_get_value(list_entry));
|
|
}
|
|
rc = 1;
|
|
}
|
|
exit:
|
|
udev_queue_unref(udev_queue);
|
|
return rc;
|
|
}
|