1
0
mirror of https://github.com/systemd/systemd.git synced 2024-11-08 11:27:32 +03:00
systemd/src/network
Thomas Hindoe Paaboel Andersen b49ffb29ed sd-bus: sd_bus_message_get_errno should only return positive errno
sd_bus_message_get_errno can currently return either a number of
different poitive errno values (from bus-error-mapping), or a negative
EINVAL if passed null as parameter.

The check for null parameter was introduced in 40ca29a137
at the same as the function was renamed from bus_message_to_errno and
made public API. Before becoming public the function used to return
only negative values.

It is weird to have a function return both positive and negative errno
and it generally looks like a mistake. The function is guarded by the
--enable-kdbus flags so I wonder if we still have time to fix it up?
It does not have any documentation yet. However, except for a few details
it is just a convenient way to call sd_bus_error_get_errno which is documented
to return only positive errno.

This patch makes it return only positive errno and fixes up the two
calls to the function that tried to cope with both positive and negative
values.
2014-09-16 21:31:15 +02:00
..
.gitignore Revert "update gitignore" 2014-05-22 06:14:41 +09:00
Makefile networkd: add a basic network daemon 2013-11-09 23:41:17 +01:00
networkctl.c networkctl: show the link file applied to each link 2014-09-08 15:09:08 +02:00
networkd-address-pool.c networkd: split out networkd-link.h 2014-08-12 20:42:59 +02:00
networkd-address.c networkd: split out networkd-link.h 2014-08-12 20:42:59 +02:00
networkd-dhcp4.c networkd: allow specification of DHCP route metric 2014-09-08 15:09:08 +02:00
networkd-ipv4ll.c networkd: link - split out ipv4ll handling 2014-08-12 20:42:59 +02:00
networkd-link.c sd-bus: sd_bus_message_get_errno should only return positive errno 2014-09-16 21:31:15 +02:00
networkd-link.h networkd: move carrier gained/lost handling from link_update_flags() to link_update() 2014-09-04 14:10:57 +02:00
networkd-manager.c hashmap: introduce hash_ops to make struct Hashmap smaller 2014-09-15 16:08:50 +02:00
networkd-netdev-bond.c networkd: bridge - use USEC_PER_MSEC macros 2014-07-21 20:54:09 +02:00
networkd-netdev-bond.h networkd: add support for bond options 2014-07-21 20:35:21 +02:00
networkd-netdev-bridge.c networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-bridge.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-dummy.c networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-dummy.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-gperf.gperf networkd: add support for bond options 2014-07-21 20:35:21 +02:00
networkd-netdev-macvlan.c networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-macvlan.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-tunnel.c networkd: split out networkd-link.h 2014-08-12 20:42:59 +02:00
networkd-netdev-tunnel.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-tuntap.c networkd: tuntap - return correct error when /dev/net/tun cannot be opened 2014-09-08 15:07:51 +02:00
networkd-netdev-tuntap.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-veth.c networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-veth.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-vlan.c networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-vlan.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev-vxlan.c networkd: split out networkd-link.h 2014-08-12 20:42:59 +02:00
networkd-netdev-vxlan.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-netdev.c networkd: netdev - failing to create a netdev is not fatal, just fail that netdev 2014-09-08 15:07:51 +02:00
networkd-netdev.h networkd: netdev - split NetDev struct into per-kind structs 2014-07-21 13:32:27 +02:00
networkd-network-gperf.gperf networkd: allow specification of DHCP route metric 2014-09-08 15:09:08 +02:00
networkd-network.c hashmap: introduce hash_ops to make struct Hashmap smaller 2014-09-15 16:08:50 +02:00
networkd-route.c networkd: add preferred source to dhcp4 gateway route 2014-09-08 15:08:27 +02:00
networkd-wait-online-link.c hashmap: introduce hash_ops to make struct Hashmap smaller 2014-09-15 16:08:50 +02:00
networkd-wait-online-link.h networkd-wait-online: track links 2014-07-17 22:53:35 +02:00
networkd-wait-online-manager.c networkd-wait-online: fix comilation warning 2014-07-18 13:25:18 +02:00
networkd-wait-online.c networkd-wait-online: add missing short option 'i' to optstring 2014-08-26 20:29:59 +02:00
networkd-wait-online.h networkd-wait-online: track links 2014-07-17 22:53:35 +02:00
networkd.c notify: send STOPPING=1 from our daemons 2014-08-21 17:24:21 +02:00
networkd.h networkd: remove vestigial event sources 2014-09-13 14:18:20 -04:00
test-network-tables.c networkd: split out networkd-link.h 2014-08-12 20:42:59 +02:00
test-network.c test-network: fix off-by-one error in test 2014-08-31 19:22:33 +02:00