1
0
mirror of https://github.com/systemd/systemd.git synced 2025-01-14 23:24:38 +03:00
systemd/coccinelle/take-fd.cocci
Mike Yuan 906682a1de coccinelle/take-fd: match for -EBADF instead of -1
Follow-up for 254d1313ae5a69c08c9b93032aaaf3d6083cfc07
2023-07-09 14:07:48 +09:00

23 lines
480 B
Plaintext

/* SPDX-License-Identifier: LGPL-2.1-or-later */
@@
local idexpression p;
expression q;
@@
- p = q;
- q = -EBADF;
- return p;
+ return TAKE_FD(q);
/* The ideal solution would use 'local idexpression' to avoid matching errno,
* which is a global variable. However, 'idexpression' nor 'identifier'
* would match, for example, "x->fd", which is considered 'expression' in
* the SmPL grammar
*/
@@
expression p != errno;
expression q;
@@
- p = q;
- q = -EBADF;
+ p = TAKE_FD(q);