virt-manager/virtManager/storagebrowse.py

155 lines
4.9 KiB
Python
Raw Normal View History

# Copyright (C) 2009, 2013, 2014 Red Hat, Inc.
# Copyright (C) 2009 Cole Robinson <crobinso@redhat.com>
#
# This work is licensed under the GNU GPLv2 or later.
# See the COPYING file in the top-level directory.
import logging
from . import uiutil
from .baseclass import vmmGObjectUI
from .storagelist import vmmStorageList
2010-12-09 01:26:19 +03:00
class vmmStorageBrowser(vmmGObjectUI):
def __init__(self, conn):
vmmGObjectUI.__init__(self, "storagebrowse.ui", "vmm-storage-browse")
self.conn = conn
self._first_run = False
self._finish_cb = None
# Passed to browse_local
self._browse_reason = None
self.storagelist = vmmStorageList(self.conn, self.builder, self.topwin,
self._vol_sensitive_cb)
self._init_ui()
self.builder.connect_signals({
"on_vmm_storage_browse_delete_event": self.close,
})
self.bind_escape_key_close()
def show(self, parent):
logging.debug("Showing storage browser")
if not self._first_run:
self._first_run = True
pool = self.conn.get_default_pool()
uiutil.set_list_selection(self.storagelist.widget("pool-list"),
pool and pool.get_connkey() or None)
2011-04-14 16:47:42 +04:00
self.topwin.set_transient_for(parent)
self.topwin.present()
self.conn.schedule_priority_tick(pollpool=True)
def close(self, ignore1=None, ignore2=None):
if self.topwin.is_visible():
logging.debug("Closing storage browser")
self.topwin.hide()
self.storagelist.close()
return 1
def _cleanup(self):
self.conn = None
self.storagelist.cleanup()
self.storagelist = None
##############
# Public API #
##############
def set_finish_cb(self, callback):
self._finish_cb = callback
def set_browse_reason(self, reason):
self._browse_reason = reason
def set_vm_name(self, name):
self.storagelist.set_name_hint(name)
def _init_ui(self):
self.storagelist.connect("browse-clicked", self._browse_clicked)
self.storagelist.connect("volume-chosen", self._volume_chosen)
self.storagelist.connect("cancel-clicked", self.close)
self.widget("storage-align").add(self.storagelist.top_box)
self.err.set_modal_default(True)
self.storagelist.err.set_modal_default(True)
Convert to use GTK3 and GObject Introspection bindings Switch over to use GObject introspection bindings for all python modules related to GObject/GTK3/etc. It is not possible to mix and match old pyggtk/pygobject manual bindings with new introspection based bindings so it must be all changed in one go. Imports like import gtk Change to from gi.repository import Gtk The vmmGObject class is changed to always inherit from GObject.GObject There is no compelling reason to avoid a GObject dep for the virt-manager TUI & it horribly messed up the code. Signal declarations are changed from vmmChooseCD.signal_new(vmmChooseCD, "cdrom-chosen", [object, str]) To __gsignals__ = { "cdrom-chosen": (GObject.SignalFlags.RUN_FIRST, None, [object, str]) } which is required by new GObject bindings Most of the rest of the change is simply dealing with renamed constants / classes. Alot of legacy compat code was removed - ie helpers which check to see if certain GTK2 methods are available are no longer required since we're mandating GTK3 only. The event loop is replaced with LibvirtGLib's event loop. Still todo - Rip out all DBus stuff & make vmmEngine class inherit GtkApplication which provides unique support & DBus method handling - Switch to use LibvirtGConfig & LibvirtGObject for libvirt interaction - Possibly switch to Python 3 too ? - Figure out why GNOME keyring is missing Introspection support My suggestion is that the standalone GIT repo for virt-install only live on as a support branch for legacy platforms. A stable-0.9 branch of virt-manager can be kept for legacy PyGtk2 based virt-manager releases. The virt-manager master branch should exclusively use GObject inspection and ideally Python3 and contain both the virt-manager and virt-install codebases in one since they are intimately related to each other & using separate GIT repos has needlessly complicated life for everyone. crobinso: Some locking fixes Misc cleanups and dropping now-useless code Fix dbus usage Fix graph cell renderer regression Fix a couple tooltip issues
2012-05-14 17:24:56 +04:00
tooltip = ""
is_remote = self.conn.is_remote()
self.storagelist.widget("browse-local").set_sensitive(not is_remote)
if is_remote:
tooltip = _("Cannot use local storage on remote connection.")
self.storagelist.widget("browse-local").set_tooltip_text(tooltip)
uiutil.set_grid_row_visible(
self.storagelist.widget("pool-autostart"), False)
uiutil.set_grid_row_visible(
self.storagelist.widget("pool-name-entry"), False)
uiutil.set_grid_row_visible(
self.storagelist.widget("pool-state-box"), False)
self.storagelist.widget("browse-local").set_visible(True)
self.storagelist.widget("browse-cancel").set_visible(True)
self.storagelist.widget("choose-volume").set_visible(True)
self.storagelist.widget("choose-volume").set_sensitive(False)
self.storagelist.widget("pool-apply").set_visible(False)
data = self.config.browse_reason_data.get(self._browse_reason)
allow_create = True
if data:
self.topwin.set_title(data["storage_title"])
allow_create = data["enable_create"]
self.storagelist.widget("vol-add").set_sensitive(allow_create)
#############
# Listeners #
#############
def _browse_clicked(self, src):
ignore = src
return self._browse_local()
def _volume_chosen(self, src, volume):
ignore = src
logging.debug("Chosen volume XML:\n%s", volume.xmlobj.get_xml())
self._finish(volume.get_target_path())
def _vol_sensitive_cb(self, fmt):
if ((self._browse_reason == self.config.CONFIG_DIR_FS) and
fmt != 'dir'):
return False
return True
####################
# Internal helpers #
####################
def _browse_local(self):
dialog_type = None
dialog_name = None
choose_button = None
data = self.config.browse_reason_data.get(self._browse_reason)
if data:
dialog_name = data["local_title"] or None
dialog_type = data.get("dialog_type")
choose_button = data.get("choose_button")
filename = self.err.browse_local(self.conn,
dialog_type=dialog_type, browse_reason=self._browse_reason,
dialog_name=dialog_name, choose_button=choose_button)
if filename:
logging.debug("Browse local chose path=%s", filename)
self._finish(filename)
def _finish(self, path):
if self._finish_cb:
self._finish_cb(self, path)
self.close()