shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-10-27 01:55:20 +03:00
Code Issues Projects Releases Wiki Activity

deviceinterface: disallow using source dev for ethernet interface

Browse Source 
Device <interface type='ethernet'/> doesn't support <source dev=''/> attribute
and we should ignore it the same way as we do for <interface type='user'/>.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2016-07-08 17:58:28 +02:00
parent 1bed021a00
commit 023a55cb39
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
virtinst/deviceinterface.py
View File

@ -182,9 +182,9 @@ class VirtualNetworkInterface(VirtualDevice):
return self._network
if self.type == self.TYPE_BRIDGE:
return self._bridge
if self.type == self.TYPE_ETHERNET or self.type == self.TYPE_DIRECT:
if self.type == self.TYPE_DIRECT:
return self._source_dev
if self.type == self.TYPE_USER:
if self.type == self.TYPE_USER or self.type == self.TYPE_ETHERNET:
return None
return self._network or self._bridge or self._source_dev
def _set_source(self, newsource):
@ -200,7 +200,7 @@ class VirtualNetworkInterface(VirtualDevice):
self._network = newsource
elif self.type == self.TYPE_BRIDGE:
self._bridge = newsource
elif self.type == self.TYPE_ETHERNET or self.type == self.TYPE_DIRECT:
elif self.type == self.TYPE_DIRECT:
self._source_dev = newsource
source = property(_get_source, _set_source)