shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-22 22:03:58 +03:00
Code Issues Projects Releases Wiki Activity

domain: don't attempt to predict if VM supports snapshots

Browse Source 
internal snapshots largely only work if the VM is backed by a single
qcow2 disk. But newly supported external snapshots support other
disk formats, and multiple disks.

Drop the old validation checking. Let's just leave it up to libvirt
to give us an error at snapshot creation time

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2024-04-07 16:12:27 -04:00 committed by Pavel Hrdina
parent e412ecf1f7
commit 07ae6da38a
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
virtManager/object/domain.py
View File

@ -473,25 +473,6 @@ class vmmDomain(vmmLibvirtObject):
if not self.conn.support.domain_list_snapshots(self._backend):
return _("Libvirt connection does not support snapshots.")
if self.list_snapshots():
return
# Check if our disks are all qcow2
seen_qcow2 = False
for disk in self.get_disk_devices_norefresh():
if disk.read_only:
continue
if disk.is_empty():
continue
if disk.driver_type == "qcow2":
seen_qcow2 = True
continue
return _("Snapshots are only supported if all writeable disks "
"images allocated to the guest are qcow2 format.")
if not seen_qcow2:
return _("Snapshots require at least one writeable qcow2 disk "
"image allocated to the guest.")
def get_domain_capabilities(self):
if not self._domain_caps:
self._domain_caps = self.get_xmlobj().lookup_domcaps()