From 0a1d22f395e86861c3725e37fec9f592a616a4ce Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Mon, 2 May 2016 17:19:15 -0400 Subject: [PATCH] console: Remove console_active check This is largely left over from the old days when a xen VM could start up but still take a bit of time for the allocated VNC port to be reflected in the XML. This may still be an issue with old old xen, but I suspect it's not relevant for anything modern, and it causes some issues with listen=none behavior that spice supports. Just drop it and see if anyone complains --- virtManager/console.py | 5 ----- virtManager/sshtunnels.py | 6 ------ 2 files changed, 11 deletions(-) diff --git a/virtManager/console.py b/virtManager/console.py index 22cd989f0..dd9baae14 100644 --- a/virtManager/console.py +++ b/virtManager/console.py @@ -652,11 +652,6 @@ class vmmConsolePages(vmmGObjectUI): "guest's listen address." % ginfo.transport)) return - if not ginfo.console_active(): - self._activate_unavailable_page( - _("Graphical console is not yet active for guest")) - return - self._activate_unavailable_page( _("Connecting to graphical console for guest")) diff --git a/virtManager/sshtunnels.py b/virtManager/sshtunnels.py index 4fe8c3f10..d49346b8c 100644 --- a/virtManager/sshtunnels.py +++ b/virtManager/sshtunnels.py @@ -98,12 +98,6 @@ class ConnectionInfo(object): (self.gtype, self.transport, self._connhost, self.connuser, self._connport, self.gaddr, self.gport, self.gtlsport, self.gsocket)) - def console_active(self): - if self.gsocket: - return True - if (self.gport in [None, -1] and self.gtlsport in [None, -1]): - return False - return True class _TunnelScheduler(object):