shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-13 13:17:57 +03:00
Code Issues Projects Releases Wiki Activity

details: Disallow removing the scsi controller if disks attached to it

Browse Source 
Through virt-manager, After we removed a virtio-scsi controller which
virtual disks still attach to it, Libvirt will add a LSI scsi controller
for this guest automatically and trigger a lifecycle event, virt-manager
updates and shows this new scsi controller in details panel once it got
the lifecycle event.

It may confuse user that a LSI scsi controller occurs while one removes
the virtio-scsi controller.

This patch prevents removing a scsi controller if any disks attaching to
it.

Signed-off-by: Lin Ma <lma@suse.com>
This commit is contained in:
Lin Ma 2017-11-23 17:32:49 +08:00 committed by Cole Robinson
parent 066b91b2a0
commit 12c5945be0
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
virtManager/details.py
View File

@ -3003,6 +3003,11 @@ class vmmDetails(vmmGObjectUI):
can_remove = False
if controller.type == "pci":
can_remove = False
if controller.type == "scsi":
for disk in self.vm.get_disk_devices():
if disk.address.compare_controller(controller, disk.bus):
can_remove = False
break
self.widget("config-remove").set_sensitive(can_remove)
type_label = controller.pretty_desc()