shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-23 17:34:21 +03:00
Code Issues Projects Releases Wiki Activity

unattended: Fix errors when running as root

Browse Source 
Tries to use 'root' as VM username, which is forbidden

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2019-11-25 12:02:27 -05:00
parent 530befc222
commit 226378d522
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
virtinst/install/unattended.py
View File

@ -42,15 +42,22 @@ def _make_installconfig(script, osobj, unattended_data, arch, hostname, url):
# Set user login and name
# In case it's specified via command-line, use the specified one as login
# and realname. Otherwise, fallback fto the one from the system
login = unattended_data.user_login or getpass.getuser()
login = login.lower()
if not is_user_login_safe(login):
raise RuntimeError(
_("%s cannot use '%s' as user-login.") % (osobj.name, login))
login = unattended_data.user_login
realname = unattended_data.user_login
if not login:
hostuser = getpass.getuser()
if is_user_login_safe(hostuser):
login = getpass.getuser()
realname = pwd.getpwnam(login).pw_gecos
realname = unattended_data.user_login or pwd.getpwnam(login).pw_gecos
config.set_user_login(login)
config.set_user_realname(realname)
if login:
login = login.lower()
if not is_user_login_safe(login):
raise RuntimeError(
_("%s cannot use '%s' as user-login.") % (osobj.name, login))
config.set_user_login(login)
config.set_user_realname(realname)
# Set user-password.
# In case it's required and not passed, just raise a RuntimeError.