shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-23 17:34:21 +03:00
Code Issues Projects Releases Wiki Activity

error: Don't double log summary

Browse Source 
details is often composed of a summary + traceback, so if users copy
it into a bug report we get all the info. But when logging the contents
we don't want to double log the summary, so try to strip it out
This commit is contained in:
Cole Robinson 2018-03-16 17:30:39 -04:00
parent 465b04ea18
commit 2f0e730efc
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
virtManager/error.py
View File

@ -102,7 +102,10 @@ class vmmErrorDialog(vmmGObject):
if debug: if debug:
debugmsg = "error dialog message:\nsummary=%s" % summary debugmsg = "error dialog message:\nsummary=%s" % summary
if details and details != summary: if details and details != summary:
debugmsg += "\ndetails=%s" % details det = details
if details.startswith(summary):
det = details[len(summary):].strip()
debugmsg += "\ndetails=%s" % det
logging.debug(debugmsg) logging.debug(debugmsg)
# Make sure we have consistent details for error dialogs # Make sure we have consistent details for error dialogs