shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-10-27 10:25:25 +03:00
Code Issues Projects Releases Wiki Activity

domain: Use UpdateDevice for CDROM media change (bz 1229819)

Browse Source 
This has been supported for a long time now, and is more tested these
days, so let's use it rather than the old style AttachDevice method

It also works around a libvirt issue described in bz 1229819
This commit is contained in:
Cole Robinson 2015-08-10 18:30:12 -04:00
parent 5f2913e5e1
commit 40d4c37868
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
virtManager/domain.py
View File

@ -800,10 +800,7 @@ class vmmDomain(vmmLibvirtObject):
_change_bus()
if do_hotplug:
hotplug_kwargs = {"device": editdev}
if path != _SENTINEL:
hotplug_kwargs["storage_path"] = True
self.hotplug(**hotplug_kwargs)
self.hotplug(device=editdev)
else:
self._redefine_xmlobj(xmlobj)
@ -1057,8 +1054,7 @@ class vmmDomain(vmmLibvirtObject):
self._backend.updateDeviceFlags(xml, flags)
def hotplug(self, vcpus=_SENTINEL, memory=_SENTINEL, maxmem=_SENTINEL,
description=_SENTINEL, title=_SENTINEL, storage_path=_SENTINEL,
device=_SENTINEL):
description=_SENTINEL, title=_SENTINEL, device=_SENTINEL):
if not self.is_active():
return
@ -1101,13 +1097,7 @@ class vmmDomain(vmmLibvirtObject):
if title != _SENTINEL:
_hotplug_metadata(title, libvirt.VIR_DOMAIN_METADATA_TITLE)
if storage_path != _SENTINEL:
# qemu originally only supported attach_device for updating
# a device's path. Stick with that. We may need to differentiate
# for other drivers that don't maintain back compat though
self.attach_device(device)
elif device != _SENTINEL:
if device != _SENTINEL:
self._update_device(device)