shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-23 17:34:21 +03:00
Code Issues Projects Releases Wiki Activity

create: Fix infinite loop after uiutil rework

Browse Source 
Repopulating the ostype/variant list triggers a bunch of change events,
which causes us to enter an infinite loop due to some minor behavior
change in the uiutil helpers.

The uiutil helpers are still correct, the root problem is we should be
disabling change events when repopulating those UI lists (we already
have to do a similar trick in a few other places, like host.py)
This commit is contained in:
Cole Robinson 2015-05-20 14:18:09 -04:00
parent bbc4f83bd3
commit 43340f46a2
1 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
virtManager/create.py
View File

@ -793,9 +793,7 @@ class vmmCreate(vmmGObjectUI):
model.append([name, label, sep, action])
def populate_os_type_model(self):
widget = self.widget("install-os-type")
model = widget.get_model()
def _fill_os_type_model(self, model):
model.clear()
# Kind of a hack, just show linux + windows by default since
@ -818,13 +816,21 @@ class vmmCreate(vmmGObjectUI):
self._add_os_row(model, sep=True)
self._add_os_row(model, label=_("Show all OS options"), action=True)
def populate_os_type_model(self):
widget = self.widget("install-os-type")
model = widget.get_model()
# Don't trigger 'change' events while repopulating
widget.set_model(None)
try:
self._fill_os_type_model(model)
finally:
widget.set_model(model)
# Select 'generic' by default
widget.set_active(0)
def populate_os_variant_model(self, _type):
widget = self.widget("install-os-version")
model = widget.get_model()
def _fill_os_variant_model(self, model, _type):
model.clear()
preferred = self.config.preferred_distros
@ -839,6 +845,17 @@ class vmmCreate(vmmGObjectUI):
self._add_os_row(model, sep=True)
self._add_os_row(model, label=_("Show all OS options"), action=True)
def populate_os_variant_model(self, _type):
widget = self.widget("install-os-version")
model = widget.get_model()
# Don't trigger 'change' events while repopulating
widget.set_model(None)
try:
self._fill_os_variant_model(model, _type)
finally:
widget.set_model(model)
widget.set_active(0)
def populate_media_model(self, model, urls):