shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-03 13:47:18 +03:00
Code Issues Projects Releases Wiki Activity

virt-install: Drop the serial extra_args warnings

Browse Source 
There's been multiple reports that these aren't really valid nowadays.
systemd is smart enough to make this work automagically. So just drop
it
This commit is contained in:
Cole Robinson 2019-06-11 15:55:34 -04:00
parent de90716eb4
commit 436c471b15
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
virt-install
View File

@ -393,28 +393,6 @@ def _show_nographics_warnings(options, guest, installer):
"see text install output from the guest."))
return
serial_arg = "console=ttyS0"
serial_arm_arg = "console=ttyAMA0"
hvc_arg = "console=hvc0"
console_type = serial_arg
if guest.os.is_arm():
console_type = serial_arm_arg
if guest.devices.console[0].target_type in ["virtio", "xen"]:
console_type = hvc_arg
if guest.os.is_ppc64() or guest.os.is_arm_machvirt() or guest.os.is_s390x():
# Later arm/ppc/s390x kernels figure out console= automatically, so
# don't warn about it.
return
for args in (options.extra_args or []):
if console_type in (args or ""):
return
logging.warning(_("Did not find '%(console_string)s' in --extra-args, "
"which is likely required to see text install output from the "
"guest."), {"console_string": console_type})
def show_warnings(options, guest, installer):
if options.pxe and not supports_pxe(guest):