shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-12 20:58:28 +03:00
Code Issues Projects Releases Wiki Activity

create: Offer to reuse an existing disk image

Browse Source 
If the disk image has the expected name /var/lib/libvirt/images/VMNAME.img,
and is unused by any guests, ask the user if they want to use it.
This commit is contained in:
Cole Robinson 2010-03-03 18:16:08 -05:00
parent 64765ec3d4
commit 5f6a59f118
1 changed files with 55 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
src/virtManager/create.py
View File

@ -823,11 +823,14 @@ class vmmCreate(gobject.GObject):
return (media.strip(), extra.strip(), ks.strip())
def is_default_storage(self):
return self.window.get_widget("config-storage-create").get_active()
def get_storage_info(self):
path = None
size = self.window.get_widget("config-storage-size").get_value()
sparse = not self.window.get_widget("config-storage-nosparse").get_active()
if self.window.get_widget("config-storage-create").get_active():
if self.is_default_storage():
path = self.get_default_path(self.guest.name)
logging.debug("Default storage path is: %s" % path)
else:
@ -835,6 +838,28 @@ class vmmCreate(gobject.GObject):
return (path, size, sparse)
def get_default_pool(self):
pool = None
for uuid in self.conn.list_pool_uuids():
p = self.conn.get_pool(uuid)
if p.get_name() == util.DEFAULT_POOL_NAME:
pool = p
if not pool:
raise RuntimeError(_("Did not find pool '%s'") %
util.DEFAULT_POOL_NAME)
return pool
def get_ideal_path_info(self, name):
pool = self.get_default_pool()
suffix = ".img"
return (pool.get_target_path(), name, suffix)
def get_ideal_path(self, name):
target, name, suffix = self.get_ideal_path_info(name)
return os.path.join(target, name) + suffix
def get_default_path(self, name):
path = ""
@ -860,20 +885,13 @@ class vmmCreate(gobject.GObject):
path = f
else:
pool = None
for uuid in self.conn.list_pool_uuids():
p = self.conn.get_pool(uuid)
if p.get_name() == util.DEFAULT_POOL_NAME:
pool = p
if not pool:
raise RuntimeError(_("Did not find pool '%s'") %
util.DEFAULT_POOL_NAME)
pool = self.get_default_pool()
target, ignore, suffix = self.get_ideal_path_info(name)
path = virtinst.Storage.StorageVolume.find_free_name(name,
pool_object=pool.pool, suffix=".img")
pool_object=pool.pool, suffix=suffix)
path = os.path.join(pool.get_target_path(), path)
path = os.path.join(target, path)
return path
@ -1353,6 +1371,31 @@ class vmmCreate(gobject.GObject):
# This can error out
diskpath, disksize, sparse = self.get_storage_info()
if self.is_default_storage() and not revalidate:
# See if the ideal disk path (/default/pool/vmname.img)
# exists, and if unused, prompt the use for using it
ideal = self.get_ideal_path(self.guest.name)
do_exist = False
ret = True
try:
do_exist = virtinst.VirtualDisk.path_exists(
self.conn.vmm, ideal)
ret = virtinst.VirtualDisk.path_in_use_by(self.conn.vmm,
ideal)
except:
logging.exception("Error checking default path usage")
if do_exist and not ret:
do_use = self.err.yes_no(
_("The following path already exists, but is not\n"
"in use by any virtual machine:\n\n%s\n\n"
"Would you like to use this path?") % ideal)
if do_use:
diskpath = ideal
if not diskpath:
return self.verr(_("A storage path must be specified."))