shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-24 21:34:47 +03:00
Code Issues Projects Releases Wiki Activity

virt-install: Warn about --location $DIR needing extra args

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=1677019
This commit is contained in:
Cole Robinson 2019-06-17 00:07:29 -04:00
parent e9308bde1f
commit 6215c86fa2
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/clitest.py
View File

@ -1074,9 +1074,8 @@ c.add_valid("--pxe --destroy-on-exit", grep="Restarting guest.\n") # destroy-on
c.add_valid("--pxe --transient --destroy-on-exit", grep="Domain creation completed.") # destroy-on-exit + transient
c.add_valid("--pxe --graphics vnc --noreboot", grep="testsuite console command: ['virt-viewer'") # mock virt-viewer waiting, with noreboot magic
c.add_valid("--nographics --cdrom %(EXISTIMG1)s") # console warning about cdrom + nographics
c.add_valid("--nographics --console none --location %(TREEDIR)s") # console warning about nographics + --console none
c.add_valid("--nographics --console none --location %(TREEDIR)s") # console warning about nographics + --console none
c.add_valid("--nographics --location %(TREEDIR)s") # console warning about nographics + missing extra args
c.add_valid("--nographics --console none --location %(TREEDIR)s", grep="No --console device added") # console warning about nographics + --console none
c.add_valid("--nographics --console none --location %(TREEDIR)s", grep="Directory tree installs typically") # warning about directory trees not working well
c.add_valid("--pxe --nographics --transient", grep="testsuite console command: ['virsh'") # --transient handling

11
virtinst/install/installertreemedia.py
View File

@ -248,8 +248,15 @@ class InstallerTreeMedia(object):
self._extra_args.append(install_args)
if self._install_kernel_args:
return self._install_kernel_args
return " ".join(self._extra_args)
ret = self._install_kernel_args
else:
ret = " ".join(self._extra_args)
if self._media_type == MEDIA_DIR and not ret:
log.warning(_("Directory tree installs typically do not work "
"unless extra kernel args are passed to point the "
"installer at a network accessible install tree."))
return ret
def prepare(self, guest, meter, unattended_script):
fetcher = self._get_fetcher(guest, meter)