shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-22 13:34:07 +03:00
Code Issues Projects Releases Wiki Activity

serialcon: Don't disable console menu items for offline VM

Browse Source 
Currently, View->Consoles disables the menu items for serial devices
when the VM is offline. This changes that behavior. This is useful,
since it allows you to pre-select serial console before starting the
VM, which can help ensure you don't miss any serial boot output.
It also makes the UI interaction more intuitive.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2024-09-07 13:27:05 -04:00
parent 2293ec49b2
commit 6264167cc1
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
virtManager/details/serialcon.py
View File

@ -170,7 +170,7 @@ class _DataStream(vmmGObject):
class vmmSerialConsole(vmmGObject):
@staticmethod
def can_connect(vm, dev):
def can_connect(_vm, dev):
"""
Check if we think we can actually open passed console/serial dev
"""
@ -179,9 +179,7 @@ class vmmSerialConsole(vmmGObject):
err = ""
if not vm.is_active():
err = _("Serial console not available for inactive guest")
elif ctype not in usable_types:
if ctype not in usable_types:
err = (_("Console for device type '%s' is not supported") % ctype)
return err