pylint: Silence output on Fedora 29

tests/pylint.cfg

@@ -3,7 +3,7 @@
 # can either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once).
-disable=Design,Similarities,invalid-name,missing-docstring,line-too-long,too-many-lines,superfluous-parens,bad-whitespace,locally-disabled,no-self-use,unnecessary-lambda,star-args,fixme,global-statement,bare-except,anomalous-backslash-in-string,broad-except,cyclic-import,bad-continuation,locally-enabled,unidiomatic-typecheck,redefined-variable-type,bad-option-value,wrong-import-position,consider-using-ternary,no-else-return,len-as-condition,inconsistent-return-statements
+disable=Design,Similarities,invalid-name,missing-docstring,line-too-long,too-many-lines,superfluous-parens,bad-whitespace,locally-disabled,no-self-use,unnecessary-lambda,star-args,fixme,global-statement,bare-except,anomalous-backslash-in-string,broad-except,cyclic-import,bad-continuation,locally-enabled,unidiomatic-typecheck,redefined-variable-type,bad-option-value,wrong-import-position,consider-using-ternary,no-else-return,len-as-condition,inconsistent-return-statements,useless-object-inheritance,consider-using-in,useless-return,assignment-from-none,chained-comparison
 enable=fixme
 
 

virt-clone

@@ -10,7 +10,7 @@ import argparse
 import logging
 import sys
 
-import virtinst.cli as cli
+from virtinst import cli
 from virtinst import Cloner
 from virtinst.cli import fail, print_stdout, print_stderr
 

virt-manager

@@ -17,8 +17,8 @@ import gi
 gi.require_version('LibvirtGLib', '1.0')
 from gi.repository import LibvirtGLib
 
-from virtinst import util as util
-from virtinst import cli as virtinstcli
+from virtinst import util
+from virtinst import cli
 from virtcli import CLIConfig
 
 # This is massively heavy handed, but I can't figure out any way to shut
@@ -170,7 +170,7 @@ def parse_commandline():
 def main():
     (options, leftovers) = parse_commandline()
 
-    virtinstcli.setupLogging("virt-manager", options.debug, False, False)
+    cli.setupLogging("virt-manager", options.debug, False, False)
 
     import virtManager
     logging.debug("virt-manager version: %s", CLIConfig.version)
@@ -286,8 +286,6 @@ if __name__ == "__main__":
         main()
     except KeyboardInterrupt:
         logging.debug("Received KeyboardInterrupt. Exiting application.")
-    except SystemExit:
-        raise
     except Exception as run_e:
         if "Gtk" not in globals():
             raise

virtManager/addhardware.py

@@ -1101,6 +1101,7 @@ class vmmAddHardware(vmmGObjectUI):
         # Any uncaught errors in this function are reported via _finish()
         page_num = self.widget("create-pages").get_current_page()
 
+        # pylint: disable=assignment-from-no-return
         if page_num == PAGE_ERROR:
             self._dev = None
             ret = True

virtManager/clone.py

@@ -649,7 +649,7 @@ class vmmCloneVM(vmmGObjectUI):
             src.set_active(STORAGE_COMBO_SHARE)
 
         # Show storage
-        row = self.storage_change_path(row)
+        self.storage_change_path(row)
 
     def change_storage_doclone_toggled(self, src):
         do_clone = src.get_active()

virtManager/connection.py

@@ -1438,8 +1438,6 @@ class vmmConnection(vmmGObject):
         e = None
         try:
             self._tick(*args, **kwargs)
-        except KeyboardInterrupt:
-            raise
         except Exception as err:
             e = err
 

virtinst/cli.py

@@ -85,8 +85,6 @@ class VirtStreamHandler(logging.StreamHandler):
             stream.write(fs % msg)
 
             self.flush()
-        except (KeyboardInterrupt, SystemExit):
-            raise
         except (UnicodeError, TypeError):
             stream.write((fs % msg).encode("utf-8"))
         except Exception: