shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-08 04:58:29 +03:00
Code Issues Projects Releases Wiki Activity

cli: Warn if we think spice GL settings won't work

Browse Source
This commit is contained in:
Cole Robinson 2016-05-20 12:44:13 -04:00
parent 8aead7619c
commit 635a228f6b
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
virtinst/cli.py
View File

@ -1912,7 +1912,17 @@ class ParserGraphics(VirtCLIParser):
if opts.fullopts == "none":
self.guest.skip_default_graphics = True
return
return VirtCLIParser._parse(self, opts, inst)
ret = VirtCLIParser._parse(self, opts, inst)
if inst.conn.is_qemu() and inst.gl:
if inst.type != "spice":
logging.warn("graphics type=%s does not support GL", inst.type)
elif not inst.conn.check_support(
inst.conn.SUPPORT_CONN_SPICE_GL):
logging.warn("qemu/libvirt version may not support spice GL")
return ret
########################
@ -2264,6 +2274,20 @@ class ParserVideo(VirtCLIParser):
self.set_param("vram", "vram")
self.set_param("vgamem", "vgamem")
def _parse(self, opts, inst):
ret = VirtCLIParser._parse(self, opts, inst)
if inst.conn.is_qemu() and inst.accel3d:
if inst.model != "virtio":
logging.warn("video model=%s does not support accel3d",
inst.model)
elif not inst.conn.check_support(
inst.conn.SUPPORT_CONN_VIDEO_VIRTIO_ACCEL3D):
logging.warn("qemu/libvirt version may not support "
"virtio accel3d")
return ret
###################
# --sound parsing #

4
virtinst/support.py
View File

@ -311,6 +311,10 @@ SUPPORT_CONN_VCPU_PLACEMENT = _make(
SUPPORT_CONN_MEM_STATS_PERIOD = _make(
function="virDomain.setMemoryStatsPeriod",
version="1.1.1", hv_version={"qemu": 0})
SUPPORT_CONN_SPICE_GL = _make(version="1.3.3",
hv_version={"qemu": "2.5.92", "test": 0})
SUPPORT_CONN_VIDEO_VIRTIO_ACCEL3D = _make(version="1.3.0",
hv_version={"qemu": "2.5.0", "test": 0})
# This is for disk <driver name=qemu>. xen supports this, but it's