shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-10 12:58:27 +03:00
Code Issues Projects Releases Wiki Activity

When catching errors catch Exception instead of RuntimeException for better error handling

Browse Source
This commit is contained in:
Daniel P. Berrange 2006-09-26 15:50:59 -04:00
parent 6c806564a2
commit 65f62a4af2
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/virtManager/create.py
View File

@ -344,7 +344,11 @@ class vmmCreate(gobject.GObject):
title=_("Creating Virtual Machine"))
progWin.run()
if self.install_error != None:
logging.error("Async job failed to create VM " + str(self.install_error))
self._validation_error_box(_("Guest Install Error"), self.install_error)
# Don't close becase we allow user to go back in wizard & correct
# their mistakes
#self.close()
return
vm = self.connection.get_vm(guest.uuid)
@ -357,10 +361,16 @@ class vmmCreate(gobject.GObject):
def do_install(self, guest):
try:
guest.start_install(False)
except RuntimeError, e:
logging.debug("Starting background install process")
dom = guest.start_install(False)
if dom == None:
self.install_error = "Guest installation failed to complete"
logging.error("Guest install did not return a domain")
else:
logging.debug("Install completed")
except Exception, e:
self.install_error = "ERROR: %s" % e
logging.exception(e)
logging.exception("Could not complete install " + str(e))
return
def browse_iso_location(self, ignore1=None, ignore2=None):