shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-09 09:57:40 +03:00
Code Issues Projects Releases Wiki Activity

urlfetcher: Use persistent HTTP session

Browse Source 
This shaves 20 seconds off the URL test suite, so probably helps
regular users too :)
This commit is contained in:
Cole Robinson 2018-03-29 17:56:40 -04:00
parent 5055d7bd19
commit 70820790ec
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
virtinst/urlfetcher.py
View File

@ -156,12 +156,25 @@ class _URLFetcher(object):
class _HTTPURLFetcher(_URLFetcher):
_session = None
def prepareLocation(self):
self._session = requests.Session()
def cleanupLocation(self):
if self._session:
try:
self._session.close()
except Exception:
logging.debug("Error closing requests.session", exc_info=True)
self._session = None
def _hasFile(self, url):
"""
We just do a HEAD request to see if the file exists
"""
try:
response = requests.head(url, allow_redirects=True)
response = self._session.head(url, allow_redirects=True)
response.raise_for_status()
except Exception as e:
logging.debug("HTTP hasFile request failed: %s", str(e))
@ -172,7 +185,7 @@ class _HTTPURLFetcher(_URLFetcher):
"""
Use requests for this
"""
response = requests.get(url, stream=True)
response = self._session.get(url, stream=True)
response.raise_for_status()
try:
size = int(response.headers.get('content-length'))