shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-10-27 10:25:25 +03:00
Code Issues Projects Releases Wiki Activity

virt-manager: Improve error reporting at startup

Browse Source 
Don't show multiple backtraces for certain errors, only log if logging
has been started.
This commit is contained in:
Cole Robinson 2010-11-11 16:34:01 -05:00
parent 026934ed3e
commit 8876217728
2 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/virt-manager.py.in
View File

@ -57,12 +57,15 @@ pylib_dir = "::PYLIBDIR::"
pyarchlib_dir = "::PYARCHLIBDIR::"
data_dir = "::DATADIR::"
logging_setup = False
def _show_startup_error(msg, details):
import gtk
from virtManager.error import vmmErrorDialog
err = vmmErrorDialog(None, 0, gtk.MESSAGE_ERROR, gtk.BUTTONS_CLOSE, "", "")
title = _("Error starting Virtual Machine Manager")
err.show_err(title + ": " + msg, details, title, async=False)
err.show_err(title + ": " + msg, details, title, async=False,
debug=False)
def setup_i18n():
locale.setlocale(locale.LC_ALL, '')
@ -128,7 +131,8 @@ def setup_logging(debug_stdout):
DIR_NAME = ".virt-manager"
FILE_NAME = "virt-manager.log"
FILE_MODE = 'a'
FILE_FORMAT = "[%(asctime)s virt-manager %(process)d] %(levelname)s (%(module)s:%(lineno)d) %(message)s"
FILE_FORMAT = ("[%(asctime)s virt-manager %(process)d] "
"%(levelname)s (%(module)s:%(lineno)d) %(message)s")
DATEFMT = "%a, %d %b %Y %H:%M:%S"
# set up logging
@ -143,21 +147,23 @@ def setup_logging(debug_stdout):
raise RuntimeError("Could not create directory %s: %s" %
(vm_dir, e))
# XXX should we get logging level from gconf, or command line args ?
filename = "%s/%s" % (vm_dir, FILE_NAME)
rootLogger = logging.getLogger()
rootLogger.setLevel(logging.DEBUG)
fileHandler = logging.handlers.RotatingFileHandler(filename, FILE_MODE, MAX_LOGSIZE, ROTATE_NUM)
fileHandler = logging.handlers.RotatingFileHandler(filename,
FILE_MODE, MAX_LOGSIZE, ROTATE_NUM)
fileHandler.setFormatter(logging.Formatter(FILE_FORMAT, DATEFMT))
rootLogger.addHandler(fileHandler)
if debug_stdout:
streamHandler = logging.StreamHandler(sys.stderr)
streamHandler.setLevel(logging.DEBUG)
streamHandler.setFormatter(logging.Formatter("%(asctime)s (%(module)s:%(lineno)d): %(message)s"))
streamHandler.setFormatter(logging.Formatter(
"%(asctime)s (%(module)s:%(lineno)d): %(message)s"))
rootLogger.addHandler(streamHandler)
global logging_setup
logging_setup = True
logging.info("Application startup")
# Register libvirt handler
@ -423,5 +429,8 @@ if __name__ == "__main__":
except SystemExit:
raise
except Exception, run_e:
logging.exception(run_e)
if logging_setup:
logging.exception(run_e)
if "gtk" not in globals():
raise
_show_startup_error(str(run_e), "".join(traceback.format_exc()))

6
src/virtManager/error.py
View File

@ -75,7 +75,7 @@ class vmmErrorDialog (gtk.MessageDialog):
def response_cb(self, src, ignore):
src.hide()
def show_err(self, summary, details, title=None, async=True):
def show_err(self, summary, details, title=None, async=True, debug=True):
self.hide()
if title is None:
@ -83,7 +83,9 @@ class vmmErrorDialog (gtk.MessageDialog):
self.set_title(title)
safe_set_text(self, summary)
self.buffer.set_text(details)
logging.debug("Uncaught Error: %s : %s" % (summary, details))
if debug:
logging.debug("Uncaught Error: %s : %s" % (summary, details))
if async:
self.show()