From 89a2a71328462d8090b9fc5cafcaf566e25306fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Tue, 24 Sep 2019 14:07:46 +0200 Subject: [PATCH] osdict: Re-purpose supports_unattended_drivers() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit supported_unattended_drivers() was originally added as a way to tell whether a guest could support pre & post installable drivers. This is wrong for two reasons: - virt-install cannot deal with post-installable drivers/agents; - pre-installable drivers are the only ones needed in order to perform an unattended installation taking advantage of virtio-win drivers; Knowing that, let's only check for pre-installable drivers in supported_unattended_drivers(). Reviewed-by: Cole Robinson Signed-off-by: Fabiano Fidêncio --- virtinst/osdict.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/virtinst/osdict.py b/virtinst/osdict.py index a077170b3..3b9fbe437 100644 --- a/virtinst/osdict.py +++ b/virtinst/osdict.py @@ -733,8 +733,7 @@ class _OsVariant(object): return self._get_drivers_location(post_inst_drivers) def supports_unattended_drivers(self, arch): - if (self._get_pre_installable_drivers(arch) and - self._get_post_installable_drivers(arch)): + if self._get_pre_installable_drivers(arch): return True return False