shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-12 20:58:28 +03:00
Code Issues Projects Releases Wiki Activity

Revert "virt-manager: prevent attach of inactive nodedevs"

Browse Source 
This reverts commit 216dc6e4e12a628ceebfd692075b3a36b7be97d8.

This was not meant to be pushed, the patch is still under review
This commit is contained in:
Cole Robinson 2022-02-11 13:59:06 -05:00
parent d1e1bc0995
commit 9643955121
1 changed files with 3 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
virtManager/addhardware.py
View File

@ -754,7 +754,7 @@ class vmmAddHardware(vmmGObjectUI):
def _build_hostdev_treeview(self):
host_dev = self.widget("host-device")
# [ xmlobj, label]
host_dev_model = Gtk.ListStore(object, str, bool)
host_dev_model = Gtk.ListStore(object, str)
host_dev.set_model(host_dev_model)
host_col = Gtk.TreeViewColumn()
text = Gtk.CellRendererText()
@ -763,28 +763,6 @@ class vmmAddHardware(vmmGObjectUI):
host_dev_model.set_sort_column_id(1, Gtk.SortType.ASCENDING)
host_dev.append_column(host_col)
def disable_finish_if_inactive(self, selection):
model, row = selection.get_selected()
if row is None:
return
hostdev = model[row]
if hostdev[1] is None:
self.widget("create-finish").set_sensitive(False)
self.widget("create-finish").set_tooltip_text()
elif hostdev[2]:
self.widget("create-finish").set_sensitive(True)
self.widget("create-finish").set_tooltip_text()
else:
tooltip = (_("%s is not active in the host system.\n"
"Please start the mdev in the host system before adding it to the guest.")
% hostdev[1])
self.widget("create-finish").set_sensitive(False)
self.widget("create-finish").set_tooltip_text(tooltip)
def _populate_hostdev_model(self, devtype):
devlist = self.widget("host-device")
model = devlist.get_model()
@ -812,26 +790,12 @@ class vmmAddHardware(vmmGObjectUI):
prettyname = "%s %s" % (
parentdev.pretty_name(), prettyname)
model.append([dev.xmlobj, prettyname, dev.is_active()])
model.append([dev.xmlobj, prettyname])
if len(model) == 0:
model.append([None, _("No Devices Available"), False])
model.append([None, _("No Devices Available")])
uiutil.set_list_selection_by_number(devlist, 0)
# enable/disable finish button for default selection
if model[0][2]:
self.widget("create-finish").set_sensitive(True)
self.widget("create-finish").set_tooltip_text()
else:
tooltip = (_("%s is not active in the host system.\n"
"Please start the mdev in the host system before adding it to the guest.")
% model[0][1])
self.widget("create-finish").set_sensitive(False)
self.widget("create-finish").set_tooltip_text(tooltip)
devlist.get_selection().connect("changed", self.disable_finish_if_inactive)
@staticmethod
def build_video_combo(vm, combo):