shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-11 05:17:59 +03:00
Code Issues Projects Releases Wiki Activity

addhardware: Don't resize dialog until we switch pages

Browse Source 
This way, large UI pieces like char page or host device combo won't
balloon out the UI.
This commit is contained in:
Cole Robinson 2010-12-11 14:51:08 -05:00
parent 6ccdf404c3
commit 965570670b
2 changed files with 16 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/virtManager/addhardware.py
View File

@ -35,11 +35,6 @@ from virtManager.createmeter import vmmCreateMeter
from virtManager.storagebrowse import vmmStorageBrowser
from virtManager.baseclass import vmmGObjectUI
VM_STORAGE_PARTITION = 1
VM_STORAGE_FILE = 2
DEFAULT_STORAGE_FILE_SIZE = 500
PAGE_ERROR = 0
PAGE_DISK = 1
PAGE_NETWORK = 2
@ -317,12 +312,6 @@ class vmmAddHardware(vmmGObjectUI):
is_local = not self.conn.is_remote()
is_storage_capable = self.conn.is_storage_capable()
notebook = self.window.get_widget("create-pages")
notebook.set_current_page(0)
# Hide the "finish" button until the appropriate time
self.window.get_widget("create-help").hide()
# Storage init
label_widget = self.window.get_widget("phys-hd-label")
if not self.host_storage_timer:
@ -442,6 +431,13 @@ class vmmAddHardware(vmmGObjectUI):
self.vm.is_hvm(),
_("Not supported for this guest type."))
# Hide all notebook pages, so the wizard isn't as big as the largest
# page
notebook = self.window.get_widget("create-pages")
for page in range(notebook.get_n_pages()):
widget = notebook.get_nth_page(page)
widget.hide()
self.set_hw_selection(0)
#########################
@ -676,9 +672,7 @@ class vmmAddHardware(vmmGObjectUI):
def hw_selected(self, src=None):
ignore = src
self._dev = None
devbox = self.window.get_widget("host-device")
devbox.hide()
notebook = self.window.get_widget("create-pages")
row = self.get_hw_selection()
if not row:
@ -690,20 +684,16 @@ class vmmAddHardware(vmmGObjectUI):
msg = row[4] or ""
if not sens:
self.window.get_widget("create-pages").set_current_page(
PAGE_ERROR)
page = PAGE_ERROR
self.window.get_widget("hardware-info").set_text(msg)
return
if page == PAGE_CHAR:
devtype = self.window.get_widget("char-device-type")
self.change_char_device_type(devtype)
elif page == PAGE_HOSTDEV:
devbox.show()
self.set_page_title(page)
self.window.get_widget("create-pages").set_current_page(page)
notebook.get_nth_page(page).show()
notebook.set_current_page(page)
def finish(self, ignore=None):
notebook = self.window.get_widget("create-pages")

7
src/vmm-add-hardware.glade
View File

@ -65,6 +65,7 @@
<widget class="GtkAlignment" id="pages-align">
<property name="visible">True</property>
<property name="left_padding">6</property>
<property name="right_padding">12</property>
<child>
<widget class="GtkNotebook" id="create-pages">
<property name="visible">True</property>
@ -1316,7 +1317,9 @@ to connect to the virtual machine.</property>
<property name="column_spacing">12</property>
<property name="row_spacing">6</property>
<child>
<widget class="GtkComboBox" id="host-device"/>
<widget class="GtkComboBox" id="host-device">
<property name="visible">True</property>
</widget>
<packing>
<property name="left_attach">1</property>
<property name="right_attach">2</property>
@ -1476,7 +1479,7 @@ to connect to the virtual machine.</property>
<widget class="GtkAlignment" id="alignment9">
<property name="visible">True</property>
<property name="top_padding">2</property>
<property name="left_padding">22</property>
<property name="left_padding">24</property>
<child>
<widget class="GtkTable" id="char-param-table">
<property name="visible">True</property>