shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-20 22:50:16 +03:00
Code Issues Projects Releases Wiki Activity

Support prompt in keyring CreateItem as well

Browse Source 
I haven't seen the implementation that needs prompt confirmation here,
though, so I haven't really tested it. The code path is pretty much the
same as in Delete, though, which I did test.
This commit is contained in:
WGH 2021-03-21 20:44:06 +03:00 committed by Cole Robinson
parent fae3fecc1e
commit 9b00bf3e1c
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
virtManager/lib/keyring.py
View File

@ -73,6 +73,14 @@ class vmmKeyring(vmmGObject):
return None
return unlocked[0]
def _do_prompt_if_needed(self, path):
if path == "/":
return
iface = Gio.DBusProxy.new_sync(self._dbus, 0, None,
"org.freedesktop.secrets", path,
"org.freedesktop.Secret.Prompt", None)
iface.Prompt("(s)", "")
def _add_secret(self, secret):
try:
props = {
@ -84,8 +92,10 @@ class vmmKeyring(vmmGObject):
"text/plain; charset=utf8")
replace = True
self._collection.CreateItem("(a{sv}(oayays)b)",
_, prompt = self._collection.CreateItem("(a{sv}(oayays)b)",
props, params, replace)
self._do_prompt_if_needed(prompt)
except Exception: # pragma: no cover
log.exception("Failed to add keyring secret")
@ -99,11 +109,7 @@ class vmmKeyring(vmmGObject):
"org.freedesktop.secrets", path,
"org.freedesktop.Secret.Item", None)
prompt = iface.Delete()
if prompt != "/":
iface = Gio.DBusProxy.new_sync(self._dbus, 0, None,
"org.freedesktop.secrets", prompt,
"org.freedesktop.Secret.Prompt", None)
iface.Prompt("(s)", "")
self._do_prompt_if_needed(prompt)
except Exception:
log.exception("Failed to delete keyring secret")