shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-12 20:58:28 +03:00
Code Issues Projects Releases Wiki Activity

cli: Call validate() on is_single objects too

Browse Source 
The way the code was nested, we skipped calling validate() on
XMLChildProperty is_single objects. There's no reason to do that,
so adjust it.

We need to do some hasattr checking here, because --os-variant and
--location objects aren't XMLBuilders with validate defined. That's
really an issue of having XMLBuilder assumptions baked into the
generic CLI parsing infrastructure. Unwinding that is for another day
This commit is contained in:
Cole Robinson 2019-06-11 11:09:56 -04:00
parent 102a49771f
commit a80242d998
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
virtinst/cli.py
View File

@ -1432,11 +1432,11 @@ class VirtCLIParser(metaclass=_InitClass):
ret = [] ret = []
try: try:
objs = self._parse(inst is None and self.guest or inst) objs = self._parse(inst is None and self.guest or inst)
if new_object:
for obj in xmlutil.listify(objs): for obj in xmlutil.listify(objs):
if validate: if validate and hasattr(obj, "validate"):
obj.validate() obj.validate()
if not new_object:
continue
if isinstance(obj, Device): if isinstance(obj, Device):
self.guest.add_device(obj) self.guest.add_device(obj)
else: else: