shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-08 04:58:29 +03:00
Code Issues Projects Releases Wiki Activity

details: Clean up media eject/insert code

Browse Source
This commit is contained in:
Cole Robinson 2015-05-19 13:57:53 -04:00
parent 776c1d97c6
commit b17c00ecca
1 changed files with 25 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
virtManager/details.py
View File

@ -1885,26 +1885,23 @@ class vmmDetails(vmmGObjectUI):
# CDROM Eject/Connect
def toggle_storage_media(self, src_ignore):
disk = self.get_hw_selection(HW_LIST_COL_DEVICE)
if not disk:
return
curpath = disk.path
devtype = disk.device
def _change_storage_media(self, devobj, newpath):
kwargs = {"path": newpath}
return vmmAddHardware.change_config_helper(self.vm.define_disk,
kwargs, self.vm, self.err, devobj=devobj)
def _eject_media(self, disk):
try:
if curpath:
# Disconnect cdrom
self.change_storage_media(disk, None)
return
self._change_storage_media(disk, None)
except Exception, e:
self.err.show_err((_("Error disconnecting media: %s") % e))
return
def _insert_media(self, disk):
try:
def change_cdrom_wrapper(src_ignore, disk, newpath):
return self.change_storage_media(disk, newpath)
devtype = disk.device
def change_cdrom_wrapper(src_ignore, devobj, newpath):
return self._change_storage_media(devobj, newpath)
# Launch 'Choose CD' dialog
if self.media_choosers[devtype] is None:
@ -1921,6 +1918,16 @@ class vmmDetails(vmmGObjectUI):
self.err.show_err((_("Error launching media dialog: %s") % e))
return
def toggle_storage_media(self, src_ignore):
disk = self.get_hw_selection(HW_LIST_COL_DEVICE)
if not disk:
return
if disk.path:
return self._eject_media(disk)
return self._insert_media(disk)
##################################################
# Details/Hardware config changes (apply button) #
##################################################
@ -2142,12 +2149,10 @@ class vmmDetails(vmmGObjectUI):
return vmmAddHardware.change_config_helper(self.vm.define_boot,
kwargs, self.vm, self.err)
# <device> defining
def change_storage_media(self, devobj, newpath):
kwargs = {"path": newpath}
return vmmAddHardware.change_config_helper(self.vm.define_disk,
kwargs, self.vm, self.err,
devobj=devobj)
#####################
# <device> defining #
#####################
def config_disk_apply(self, devobj):
kwargs = {}