From b2659c0cba63da328ba88266c877707895ab0786 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Fri, 15 Jul 2011 15:38:59 -0400 Subject: [PATCH] manager: Don't fetch domain XML on every tick, getting the --- src/virtManager/manager.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/virtManager/manager.py b/src/virtManager/manager.py index fe62894a3..0cffa2139 100644 --- a/src/virtManager/manager.py +++ b/src/virtManager/manager.py @@ -675,7 +675,7 @@ class vmmManager(vmmGObjectUI): vm = connection.get_vm(vmuuid) vm.connect("status-changed", self.vm_status_changed) vm.connect("resources-sampled", self.vm_resources_sampled) - vm.connect("config-changed", self.vm_resources_sampled) + vm.connect("config-changed", self.vm_resources_sampled, True) vmlist = self.widget("vm-list") model = vmlist.get_model() @@ -718,8 +718,7 @@ class vmmManager(vmmGObjectUI): color = gtk.gdk.Color(23296, 23296, 23296) return color - def _build_vm_markup(self, vm, row): - ignore = vm + def _build_vm_markup(self, row): domtext = ("%s" % row[ROW_NAME]) statetext = "%s" % row[ROW_STATUS] @@ -740,7 +739,7 @@ class vmmManager(vmmGObjectUI): row.insert(ROW_IS_VM_RUNNING, vm.is_active()) row.insert(ROW_COLOR, None) - row[ROW_MARKUP] = self._build_vm_markup(vm, row) + row[ROW_MARKUP] = self._build_vm_markup(row) return row @@ -859,7 +858,7 @@ class vmmManager(vmmGObjectUI): self.vm_selected() self.vm_resources_sampled(vm) - def vm_resources_sampled(self, vm): + def vm_resources_sampled(self, vm, config_changed=False): vmlist = self.widget("vm-list") model = vmlist.get_model() @@ -871,8 +870,11 @@ class vmmManager(vmmGObjectUI): row[ROW_STATUS] = vm.run_status() row[ROW_STATUS_ICON] = vm.run_status_icon_name() row[ROW_IS_VM_RUNNING] = vm.is_active() - row[ROW_MARKUP] = self._build_vm_markup(vm, row) - row[ROW_HINT] = vm.get_description() + row[ROW_MARKUP] = self._build_vm_markup(row) + + if config_changed: + row[ROW_HINT] = vm.get_description() + model.row_changed(row.path, row.iter) def conn_state_changed(self, conn): @@ -890,8 +892,8 @@ class vmmManager(vmmGObjectUI): row[ROW_STATUS] = ("%s" % conn.get_state_text()) row[ROW_IS_CONN_CONNECTED] = conn.state != conn.STATE_DISCONNECTED - row[ROW_HINT] = self._build_conn_hint(conn) row[ROW_COLOR] = self._build_conn_color(conn) + row[ROW_HINT] = self._build_conn_hint(conn) if conn.get_state() in [vmmConnection.STATE_DISCONNECTED, vmmConnection.STATE_CONNECTING]: