shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-11 05:17:59 +03:00
Code Issues Projects Releases Wiki Activity

virt-install: Add --test-stub-command

Browse Source 
Fills in basic install options to make the command succeed. Saves
devs having to type boiler plate options when testing new command
line bits
This commit is contained in:
Cole Robinson 2018-06-12 10:50:36 -04:00
parent 876c79cc15
commit b6cd46b382
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/clitest.py
View File

@ -706,6 +706,7 @@ c = vinst.add_category("misc-install", "--nographics --noautoconsole")
c.add_valid("--disk path=%(EXISTIMG1)s,device=cdrom") # Implied cdrom install
c.add_compare("", "noargs-fail", auto_printarg=False) # No arguments
c.add_valid("--panic help --disk=?") # Make sure introspection doesn't blow up
c.add_valid("--test-stub-command") # --test-stub-command
c.add_invalid("--hvm --nodisks --pxe foobar") # Positional arguments error
c.add_invalid("--nodisks --pxe --name test") # Colliding name

26
virt-install
View File

@ -840,6 +840,9 @@ def parse_args():
# Takes a URL and just prints to stdout the detected distro name
insg.add_argument("--test-media-detection", help=argparse.SUPPRESS)
# Helper for cli testing, fills in standard stub options
insg.add_argument("--test-stub-command", action="store_true",
help=argparse.SUPPRESS)
insg.add_argument("--os-type", dest="distro_type", help=argparse.SUPPRESS)
insg.add_argument("--os-variant", dest="distro_variant",
@ -926,6 +929,28 @@ def parse_args():
# main() handling #
###################
def set_test_stub_options(options):
# Set some basic options that will let virt-install succeed. Helps
# save boiler plate typing when testing new command line additions
if not options.test_stub_command:
return
if not options.connect:
options.connect = "test:///default"
if not options.name:
options.name = "test-stub-command"
if not options.memory:
options.memory = "256"
if not options.disk:
options.disk = "none"
if not install_specified(options):
options.import_install = True
if not options.graphics:
options.graphics = "none"
if not options.distro_variant:
options.distro_variant = "fedora27"
def main(conn=None):
cli.earlyLogging()
options = parse_args()
@ -951,6 +976,7 @@ def main(conn=None):
convert_old_features(options)
convert_old_cpuset(options)
convert_old_init(options)
set_test_stub_options(options)
convert_old_os_options(options)
if conn is None: