mirror of
https://github.com/virt-manager/virt-manager.git
synced 2024-10-26 08:55:13 +03:00
storage: Replace volume supports_property with supports_format
Helps to make usage more explicit
This commit is contained in:
parent
657b2bcb26
commit
b8074b4505
@ -123,7 +123,7 @@ class vmmCreateVolume(vmmGObjectUI):
|
||||
|
||||
vol = self._make_stub_vol()
|
||||
|
||||
hasformat = vol.supports_property("format")
|
||||
hasformat = vol.supports_format()
|
||||
uiutil.set_grid_row_visible(self.widget("vol-format"), hasformat)
|
||||
uiutil.set_list_selection(self.widget("vol-format"),
|
||||
self.conn.get_default_storage_format())
|
||||
|
@ -184,7 +184,7 @@ class vmmAddStorage(vmmGObjectUI):
|
||||
disk.set_vol_install(vol_install)
|
||||
|
||||
fmt = self.conn.get_default_storage_format()
|
||||
if disk.get_vol_install().supports_property("format"):
|
||||
if disk.get_vol_install().supports_format():
|
||||
log.debug("Using default prefs format=%s for path=%s",
|
||||
fmt, disk.path)
|
||||
disk.get_vol_install().format = fmt
|
||||
|
@ -239,7 +239,7 @@ class DeviceDisk(Device):
|
||||
volinst.backing_format = backing_format
|
||||
|
||||
if fmt:
|
||||
if not volinst.supports_property("format"):
|
||||
if not volinst.supports_format():
|
||||
raise ValueError(_("Format attribute not supported for this "
|
||||
"volume type"))
|
||||
volinst.format = fmt
|
||||
|
@ -459,7 +459,7 @@ class _StorageCreator(_StorageBase):
|
||||
|
||||
def get_driver_type(self):
|
||||
if self._vol_install:
|
||||
if self._vol_install.supports_property("format"):
|
||||
if self._vol_install.supports_format():
|
||||
return self._vol_install.format
|
||||
return "raw"
|
||||
|
||||
|
@ -643,7 +643,7 @@ class StorageVolume(_StorageObject):
|
||||
log.debug("Found backing store volume XML:\n%s",
|
||||
volxml.get_xml())
|
||||
|
||||
if volxml.supports_property("format"):
|
||||
if volxml.supports_format():
|
||||
log.debug("Returning format=%s", volxml.format)
|
||||
return volxml.format
|
||||
|
||||
@ -656,18 +656,13 @@ class StorageVolume(_StorageObject):
|
||||
# Public API helpers #
|
||||
######################
|
||||
|
||||
def _supports_format(self):
|
||||
def supports_format(self):
|
||||
if self.file_type == self.TYPE_FILE:
|
||||
return True
|
||||
if self._pool_xml.type == StoragePool.TYPE_GLUSTER:
|
||||
return True
|
||||
return False
|
||||
|
||||
def supports_property(self, propname):
|
||||
if propname == "format":
|
||||
return self._supports_format()
|
||||
return hasattr(self, propname)
|
||||
|
||||
|
||||
##################
|
||||
# Build routines #
|
||||
|
Loading…
Reference in New Issue
Block a user