shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-09 08:58:27 +03:00
Code Issues Projects Releases Wiki Activity

cli: Add --disk wwn

Browse Source 
XML mapping:

<disk>
  <wwn>...</wwn>
</disk>

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
This commit is contained in:
Athina Plaskasoviti 2019-05-17 18:26:02 +03:00 committed by Cole Robinson
parent 0366eb15e2
commit d171489f7d
6 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/cli-test-xml/compare/virt-install-many-devices.xml
View File

@ -42,6 +42,7 @@
<source file="/dev/default-pool/UPPER"/> <source file="/dev/default-pool/UPPER"/>
<target dev="vda" bus="virtio"/> <target dev="vda" bus="virtio"/>
<serial>WD-WMAP9A966149</serial> <serial>WD-WMAP9A966149</serial>
<wwn>123456789abcdefa</wwn>
<shareable/> <shareable/>
<boot order="2"/> <boot order="2"/>
</disk> </disk>

2
tests/clitest.py
View File

@ -546,7 +546,7 @@ vcpus.vcpu.id=3,vcpus.vcpu0.enabled=yes,vcpus.vcpu0.order=3,\
vcpus.vcpu1.id=2,vcpus.vcpu1.enabled=yes vcpus.vcpu1.id=2,vcpus.vcpu1.enabled=yes
--cpu none --cpu none
--disk /dev/default-pool/UPPER,cache=writeback,io=threads,perms=sh,serial=WD-WMAP9A966149,boot_order=2 --disk /dev/default-pool/UPPER,cache=writeback,io=threads,perms=sh,serial=WD-WMAP9A966149,wwn=123456789abcdefa,boot_order=2
--disk %(NEWIMG1)s,sparse=false,size=.001,perms=ro,error_policy=enospace,discard=unmap,detect_zeroes=unmap,address.type=drive,address.controller=0,address.target=2,address.unit=0 --disk %(NEWIMG1)s,sparse=false,size=.001,perms=ro,error_policy=enospace,discard=unmap,detect_zeroes=unmap,address.type=drive,address.controller=0,address.target=2,address.unit=0
--disk device=cdrom,bus=sata,read_bytes_sec=1,read_iops_sec=2,write_bytes_sec=5,write_iops_sec=6,driver.copy_on_read=on,geometry.cyls=16383,geometry.heads=16,geometry.secs=63,geometry.trans=lba --disk device=cdrom,bus=sata,read_bytes_sec=1,read_iops_sec=2,write_bytes_sec=5,write_iops_sec=6,driver.copy_on_read=on,geometry.cyls=16383,geometry.heads=16,geometry.secs=63,geometry.trans=lba
--disk size=1 --disk size=1

1
tests/xmlparse-xml/change-disk-out.xml
View File

@ -23,6 +23,7 @@
<target dev="hda" bus="usb" removable="on"/> <target dev="hda" bus="usb" removable="on"/>
<serial>frob</serial> <serial>frob</serial>
<driver name="test" type="raw"/> <driver name="test" type="raw"/>
<wwn>123456789abcdefa</wwn>
</disk> </disk>
<disk type="block" device="disk"> <disk type="block" device="disk">
<source dev="/dev/null"> <source dev="/dev/null">

1
tests/xmlparse.py
View File

@ -377,6 +377,7 @@ class XMLParseTest(unittest.TestCase):
check("driver_name", None, "test") check("driver_name", None, "test")
check("driver_type", None, "raw") check("driver_type", None, "raw")
check("serial", "WD-WMAP9A966149", "frob") check("serial", "WD-WMAP9A966149", "frob")
check("wwn", None, "123456789abcdefa")
check("bus", "ide", "usb") check("bus", "ide", "usb")
check("removable", None, False, True) check("removable", None, False, True)

1
virtinst/cli.py
View File

@ -2912,6 +2912,7 @@ class ParserDisk(VirtCLIParser):
cls.add_arg("snapshot", "snapshot_policy") cls.add_arg("snapshot", "snapshot_policy")
cls.add_arg("sgio", "sgio") cls.add_arg("sgio", "sgio")
cls.add_arg("serial", "serial") cls.add_arg("serial", "serial")
cls.add_arg("wwn", "wwn")
cls.add_arg("readonly", "read_only", is_onoff=True) cls.add_arg("readonly", "read_only", is_onoff=True)
cls.add_arg("shareable", "shareable", is_onoff=True) cls.add_arg("shareable", "shareable", is_onoff=True)

1
virtinst/devices/disk.py
View File

@ -657,6 +657,7 @@ class DeviceDisk(Device):
error_policy = XMLProperty("./driver/@error_policy") error_policy = XMLProperty("./driver/@error_policy")
serial = XMLProperty("./serial") serial = XMLProperty("./serial")
wwn = XMLProperty("./wwn")
startup_policy = XMLProperty("./source/@startupPolicy") startup_policy = XMLProperty("./source/@startupPolicy")
logical_block_size = XMLProperty("./blockio/@logical_block_size") logical_block_size = XMLProperty("./blockio/@logical_block_size")
physical_block_size = XMLProperty("./blockio/@physical_block_size") physical_block_size = XMLProperty("./blockio/@physical_block_size")