shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-10-27 01:55:20 +03:00
Code Issues Projects Releases Wiki Activity

devices: char: Remove uncalled supports_property values

Browse Source
This commit is contained in:
Cole Robinson 2019-05-13 13:18:41 -04:00
parent 1bf970627e
commit e11ed3ce77
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
virtinst/devices/char.py
View File

@ -93,28 +93,16 @@ class _DeviceChar(Device):
return desc
def supports_property(self, propname, ro=False):
def supports_property(self, propname):
"""
Whether the character dev type supports the passed property name
"""
users = {
"source_path": [self.TYPE_FILE, self.TYPE_UNIX,
self.TYPE_DEV, self.TYPE_PIPE],
"source_mode": [self.TYPE_UNIX, self.TYPE_TCP],
"source_channel": [self.TYPE_SPICEPORT],
"source_master": [self.TYPE_NMDM],
"source_slave": [self.TYPE_NMDM],
"protocol": [self.TYPE_TCP],
"bind_host": [self.TYPE_UDP],
"bind_service": [self.TYPE_UDP],
"connect_host": [self.TYPE_TCP, self.TYPE_UDP],
"connect_service": [self.TYPE_TCP, self.TYPE_UDP],
}
if ro:
users["source_path"] += [self.TYPE_PTY]
if users.get(propname):
return self.type in users[propname]
return hasattr(self, propname)
@ -182,7 +170,8 @@ class _DeviceChar(Device):
##################
def set_defaults(self, _guest):
if not self.source_mode and self.supports_property("source_mode"):
if (not self.source_mode and
self.type in [self.TYPE_UNIX, self.TYPE_TCP]):
self.source_mode = "bind"
if not self.target_type and self.DEVICE_TYPE == "channel":
self.target_type = "virtio"