shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-10-26 08:55:13 +03:00
Code Issues Projects Releases Wiki Activity

cli: --osinfo detect=on shouldn't default to require=off

Browse Source 
The require= behavior should be AUTO for this case, but the
way we were previously initializing variables made this OFF.
I don't think this was intentional. We should have changed
this when we started defaulting to `detect=on`

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2024-10-09 10:04:19 -04:00 committed by Pavel Hrdina
parent 1487dbd200
commit e3da4337f6
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_cli.py
View File

@ -1023,7 +1023,7 @@ c.add_compare("--location https://foobar.com --os-variant detect=yes,name=win7",
c.add_compare("--pxe --os-variant detect=yes,name=win7", "os-detect-fail-fallback") # os detection succeeds, so fallback should be ignored
c.add_compare("--connect %(URI-KVM-X86)s --install fedora26", "osinfo-url") # getting URL from osinfo
c.add_invalid("--pxe --os-variant detect=yes,require=yes", grep="--os-variant/--osinfo OS name is required") # No os-variant detected, but require=yes
c.add_valid("--pxe --osinfo detect=yes") # --osinfo detect=on failed, but with implied require=no
c.add_invalid("--pxe --osinfo detect=yes", grep="--os-variant/--osinfo OS name is required") # --osinfo detect=on failed, but with implied require=yes
c.add_invalid("--pxe --virt-type foobar", grep="Host does not support domain type")
c.add_invalid("--pxe --os-variant farrrrrrrge", grep="Unknown OS name")
c.add_invalid("--pxe --boot menu=foobar", grep="menu must be 'yes' or 'no'")

3
virtinst/cli.py
View File

@ -1919,9 +1919,6 @@ class OSVariantData(object):
if osobj:
self._name = osobj.name
if self._require_from_cli is None and not self._require:
self._require_from_cli = False
if self._require_from_cli is False:
self._require = self._REQUIRE_OFF
elif self._require_from_cli is True: