shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-11 16:58:31 +03:00
Code Issues Projects Releases Wiki Activity

delete: Default to not removing storage for disk removal

Browse Source 
This is the old default we've always used, so better to stick with it

Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
Cole Robinson 2020-01-28 11:16:19 -05:00
parent 03a6272f81
commit e48ce4a31e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
virtManager/delete.py
View File

@ -113,7 +113,8 @@ class _vmmDeleteBase(vmmGObjectUI):
self.widget("delete-warn-running-vm-box"), vm_active)
# Enable storage removal by default
self.widget("delete-remove-storage").set_active(True)
remove_storage_default = self._get_remove_storage_default()
self.widget("delete-remove-storage").set_active(remove_storage_default)
self.widget("delete-remove-storage").toggled()
diskdatas = self._get_disk_datas()
_populate_storage_list(self.widget("delete-storage-list"),
@ -273,6 +274,9 @@ class _vmmDeleteBase(vmmGObjectUI):
def _destroy_vm(self, vm):
raise NotImplementedError
def _get_remove_storage_default(self):
raise NotImplementedError
class vmmDeleteDialog(_vmmDeleteBase):
"""
@ -281,6 +285,9 @@ class vmmDeleteDialog(_vmmDeleteBase):
def _get_dialog_title(self):
return self.vm.get_name()
def _get_remove_storage_default(self):
return True
def _get_disk_datas(self):
return _build_diskdata_for_vm(self.vm)
@ -359,6 +366,9 @@ class vmmDeleteStorage(_vmmDeleteBase):
def _get_dialog_title(self):
return self.disk.target
def _get_remove_storage_default(self):
return False
def _get_disk_datas(self):
return [_DiskData.from_disk(self.disk)]